hendrikmuhs / ccache-action

github action to speedup building using ccache
MIT License
114 stars 52 forks source link

Add a new flag `create-symlink` #172

Closed UNIDY2002 closed 9 months ago

UNIDY2002 commented 9 months ago

It is an optional flag, so it should not break existing usages.

Why this PR work?

References:

These links above all point out that we can use a symlink to let ccache override the default compilers.

hendrikmuhs commented 9 months ago

Nice addition, thanks for your contribution!

anr2me commented 9 months ago

Btw, should i ignored this warning from github's action/workflow? will create-symlink still work?

Warning: Unexpected input(s) 'create-symlink', valid inputs are ['key', 'restore-keys', 'max-size', 'verbose', 'variant', 'save', 'append-timestamp']
UNIDY2002 commented 9 months ago

@anr2me Sorry for the confusion in documentation. I think we should directly use the action from main, like here. Would you check whether the warning disappears after using the action directly from main?

@hendrikmuhs Sorry for the mistake in documentation. Would you mind updating the documentation of this repository to fix it up? Thanks :) https://github.com/hendrikmuhs/ccache-action/blob/2a51777f6f64b7b7bea213601acba8f5f4fdbe03/README.md?plain=1#L42

anr2me commented 9 months ago

Yes, the warning disappear when using main, thanks

hendrikmuhs commented 8 months ago

@hendrikmuhs Sorry for the mistake in documentation. Would you mind updating the documentation of this repository to fix it up? Thanks :)

I've created a new release and updated the tags, the instructions should work from now on.