search

hendrikmuhs / ccache-action

github action to speedup building using ccache
MIT License
114 stars 52 forks source link

adjust key computation to avoid trailing `-` #186

Open compnerd opened 6 months ago

compnerd commented 6 months ago

The - suffix was being applied unconditionally resulting in a hanging - suffix if no timestamp was used. Adjust the key computation to remove the trailing - if no timestamp is used.

hendrikmuhs commented 6 months ago

The change also affects restore keys. I am a bit afraid of unwanted side effects. It looks like a breaking change at the moment.

What about only removing the - or appending no_timestamp or something similar?

compnerd commented 6 months ago

What about only removing the -

Hmm, this was the effect that I was going for. Perhaps I misunderstood the code and did something incorrectly for accomplishing the desired effect?

appending no_timestamp or something similar?

That does still add a suffix which does make it harder to find the cache entry when you have a number of them unfortunately :(.