Make ccache-action respect environment variables

hendrikmuhs / ccache-action

github action to speedup building using ccache

MIT License

123 stars 54 forks source link

Closed TrentHouliston closed 4 months ago

TrentHouliston commented 4 months ago

Currently, if environment variables are set for CCACHE_DIR or SCCACHE_DIR then this action will ignore them and hardcode its own.

This is a problem if CCACHE_DIR is set for example in a docker file environment which is very hard to eliminate

Fixes #96

I think this is a better solution than #165 as that one still suffers from an invalid operation if either of the environment variables are set.

hendrikmuhs commented 4 months ago

Nice! This seems fine to me, let's just run the tests.

hendrikmuhs commented 4 months ago

@TrentHouliston can you look into the errors? Seems easy to fix.

hendrikmuhs commented 4 months ago

@krlmlr WDYT? Does this solve your use case?

hendrikmuhs commented 4 months ago

Regardless of #165 this change is ready and makes sense.

Thanks for the contribution @TrentHouliston ! Do you require a release?

TrentHouliston commented 4 months ago

@hendrikmuhs A release would be good so I don't have to keep using my fork

krlmlr commented 3 months ago

Thanks. I'll review and get back here if problems arise.