search

hendrikmuhs / ccache-action

github action to speedup building using ccache
MIT License
118 stars 53 forks source link

Change Bash to Shell everywhere #223

Closed hansfn closed 2 months ago

hansfn commented 3 months ago

Updates function names to match the earlier change from "bash" to "sh". Removes last instance of "bash" execution.

Resolves #215

hansfn commented 3 months ago

Do you normally update the dist folder just before a release or do you want the commit / PR to update both the source and dist files (like I did here). If I hadn't touch the dist files, I would have avoided the EOL file issue. Another way to avoid the EOL problem would have been to compile the source of course. I just edited the dist files by hand. My bad.

hansfn commented 3 months ago

Another observation: The ccache stats are displayed without using the shell wrapper - any reason for this? It seems inconsistent.

hendrikmuhs commented 2 months ago

Sorry for the slow response. I am currently on vacation.

I don't remember a reason for ccache stats not using a shell wrapper. If I remember correctly the shell wrapper was added later only for some functions.

Another way to avoid the EOL problem would have been to compile the source of course.

I agree, this would be better. I simply do not find the time to do such improvements.