search

hendrikmuhs / ccache-action

github action to speedup building using ccache
MIT License
118 stars 53 forks source link

Fails on windows-2019 runners #93

Open amtep opened 2 years ago

amtep commented 2 years ago

When I do runs-on: windows-latest it works, but I'm working on a project (realm-js) that builds on windows-2019. The ccache action fails there with:

Error: Unable to locate executable file: sudo. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also verify the file has a valid extension for an executable file.

I think it's not detecting that it's on a windows platform, and thinks it's on linux.

I made a small demo of the issue at https://github.com/amtep/nonogram-qt/runs/7838787691

jonashaag commented 2 years ago

Thanks for the report. Can you try to contribute a fix?

amtep commented 2 years ago

No sorry, I'm stumped. I think it's that process.platform call, but I'm not sure and I have no idea why it would return the wrong thing anyway. I also have zero experience with TypeScript.

amtep commented 2 years ago

If I run with the latest (untagged) commit of this action, it works :)

So no code change is needed, just a new release.

jonesmz commented 2 years ago

Related to this, if I use hendrikmuhs/ccache-action@v1.2, i can build on windows 2019.

However, if i use hendrikmuhs/ccache-action@v1, i cant.

This makes me think something isn't set up with how github does version checks for "major releases".