search

hendriks73 / ffsampledsp

FFmpeg based service provider for javax.sound.sampled.
GNU Lesser General Public License v2.1
24 stars 5 forks source link

Add binaries for ARM #17

Closed MMarco94 closed 1 year ago

MMarco94 commented 1 year ago

Could you please add binaries so this library can work on ARM on Linux?

Thanks!

hendriks73 commented 1 year ago

What's the actual target platform? Are you thinking of a specific Linux for ARM OS? Like Android?

MMarco94 commented 1 year ago

What's the actual target platform?

linux-arm64 and ideally linux-arm32.

I don't have a specific device in mind, but there are plenty of ARM devices running Linux: Chromebooks, M1 macs with Ashai linux, tablets and some laptops.

hendriks73 commented 1 year ago

v0.9.52 should now work on linux-arm64. However, since GitHub does not offer any arm64 runners, it's difficult to test this in the CI/CD pipeline.

If you have access to a Linux arm64 system, please test it manually and report back. Here's the maven dependency you should use for that:

<dependency>
    <groupId>com.tagtraum</groupId>
    <artifactId>ffsampledsp-complete</artifactId>
    <version>0.9.52</version>
</dependency>

I do not plan to add arm32.

MMarco94 commented 1 year ago

Thanks! I don't have access to an ARM linux host, however I've asked a friend. I'll let you know

hendriks73 commented 1 year ago

Any news on this one?

MMarco94 commented 1 year ago

No sorry, I went on holidays and didn't follow up. I've sent him a message :)

hendriks73 commented 1 year ago

Any response?

I'd like to close this issue with a confirmation that things work, but will close it anyway in August.

hendriks73 commented 1 year ago

I'm closing this issue, as the implementation work has been done and there is little reason to believe that it does not work. That said, obviously, without a proper test we cannot know. If you find that it does not work on 64 bit ARM Linux, please create a new issue.

Thanks.