search

hendriks73 / tempo-cnn

Framework for estimating temporal properties of music tracks.
GNU Affero General Public License v3.0
87 stars 12 forks source link

Python 3.8+ (tensorflow 2) version #13

Open alastair opened 2 years ago

alastair commented 2 years ago

Hi! Currently this package requires tensorflow 1.15, which only has wheels on pypi for python 3.7. What are our options for running on more modern versions of python? I don't do much deep learning but my understanding is that tensorflow 2 has a different API, is that right?

hendriks73 commented 2 years ago

The TF/Keras API hasn't changed all that much and in theory one should be able to load and run the models under TF 2. Frankly, I'd be very happy to migrate the whole repo to TF/Keras 2, but haven't found the time yet.

When do you need this?

alastair commented 2 years ago

No real rush - I was doing some experiments and my default virtualenv was using py3.9, I've since downgraded python to run this. If our experiments turn out well, I can send an update with a more concrete answer about when it'd be useful.

pieface- commented 2 years ago

The models work fine on tensorflow 2.9 if you change the name of the model before running. i.e. classifier.model._name = "fixedname"

floydback commented 1 year ago

any updates?