search

hendt / ebay-api

eBay Node API in TypeScript for Node and Browser with RESTful and Traditional APIs. This library aims to implement all available eBay apis.
https://hendt.gitbook.io/ebay-api
MIT License
149 stars 40 forks source link

listingStartDate not on type EbayOfferDetailsWithId #154

Closed zenith77 closed 1 year ago

zenith77 commented 1 year ago

Hi there,

As per description; listingStartDate not on type EbayOfferDetailsWithId

https://developer.ebay.com/api-docs/sell/inventory/resources/offer/methods/createOffer#request.listingStartDate

Cheers, Col.

zenith77 commented 1 year ago

@dantio hi there - are you able to look into this?

dantio commented 1 year ago

Thank you for reporting this issue. I have looked into this and already committed changes into master branch. I have found some other missing types and decided to use types directly generated by openai. I have to test it and will release a new version next week after I'm back from vacation. Right now you can use the GitHub repo as npm source. It should solve your issue.

zenith77 commented 1 year ago

Brilliant - thanks mate! :D

And as a general point - thanks so much for your work on this library!

zenith77 commented 1 year ago

@dantio are you able to get round to pushing out a new version?

dantio commented 1 year ago

@zenith77 more changes than I expected. The release 8.50 should fix all inconsistent types since they are now generated with openapi-typescript

zenith77 commented 1 year ago

Thanks Dantio - I look forward to updating!