search

hengli / camodocal

CamOdoCal: Automatic Intrinsic and Extrinsic Calibration of a Rig with Multiple Generic Cameras and Odometry
Other
1.16k stars 389 forks source link

CameraRigBA::matchFrameToFrame allows to use only SURF_GPU for feature detection and matching #117

Open sandeepnmenon opened 2 years ago

sandeepnmenon commented 2 years ago

As shown in the code below https://github.com/hengli/camodocal/blob/b399fa9ee81b5182e59f717e67a8ddd6503cdcb4/src/calib/CameraRigBA.cc#L1476-L1483

Unlike in FeatureTracker.cc, there is no support for switching between detectors and matchers. The code can be improved here to accept m_detectorType, m_descriptorType and m_matchTestType

Are PRs accepted? I see no PRs accepted post 2017

hengli commented 2 years ago

PRs are definitely accepted. Due to lack of time, I have not been maintaining this repository, and help with this would definitely be appreciated.

On Thu, 26 May 2022 at 8:23 AM, Sandeep N Menon @.***> wrote:

As shown in the code below

https://github.com/hengli/camodocal/blob/b399fa9ee81b5182e59f717e67a8ddd6503cdcb4/src/calib/CameraRigBA.cc#L1476-L1483

Unlike in FeatureTracker.cc, there is no support for switching between detectors and matchers. The code can be improved here to accept m_detectorType, m_descriptorType and m_matchTestType

Are PRs accepted? I see no PRs accepted post 2017

— Reply to this email directly, view it on GitHub https://github.com/hengli/camodocal/issues/117, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADXAZWXHAHNT4OPZU47QM3VL5ULVANCNFSM5XBAYSIQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>