search

henicosa / PartiDeck

https://henicosa.github.io/PartiDeck/
0 stars 0 forks source link

WEBSITE adapt element sizes to moblile view #7

Open GorgeousOne opened 1 year ago

GorgeousOne commented 1 year ago

Text and elements look tiny on mobile devices. card As mentioned in the pull request the css should be updated to mobile first.

henicosa commented 1 year ago

I would prefer Mobile-First!

You can also simulate the website for different devices with the development mode of your browser. https://firefox-source-docs.mozilla.org/devtools-user/responsive_design_mode/index.html

In the same way we design CSS mobile first we should also think about js functionality mobile first.

🦆

Am 22. Juni 2023 12:17:45 MESZ schrieb Bunchie @.***>:

Text and elements look tiny on mobile devices. card Before tackling this with media tags it could be useful to determine if there are preferences for either a mobile-first or desktop-first design. (This was the first time I read about this, I found this quite enlightening: https://stackoverflow.com/a/24640497/7636794)

-- Reply to this email directly or view it on GitHub: https://github.com/henicosa/PartiDeck/issues/7 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

henicosa commented 1 year ago

So, as pointed out in this pull request.

We could force the card to the same aspect ratio in mobile view, which would be preferred in my opinion.

Right now it just scales from top to bottom:

grafik

Proposed solution: Use media query to add min-height when aspect ratio changes