search

henkaku-center / henkaku-nengajo-frontend

https://nengajo.henkaku.org/
8 stars 14 forks source link

Add header and footer #23

Closed alecrem closed 1 year ago

alecrem commented 1 year ago

Some reference:

imaichiyyy commented 1 year ago

I need your judgment on the following.

Menu items displayed in the header

Is there anything else you would like to set for the menu besides the following that you have in mind? (or if there is any functionality that we may not need 🙏 )

Home

Register

About footer items

In the footer of omise, there are links to Twitter and GitHub repositories, do you want to display these as well?

alecrem commented 1 year ago

Thank you! This is very detailed and helpful.

Register

SGTM 🙆

Nengajo

I think it makes sense for the home page to be the list of registered nengajos. What does everyone think?

Light / DarkMode and i18n

These are not implemented and I think it would make sense to leave them for a future PR. But please keep them in mind when thinking about the layout. It's also okay if you would like to include dummy buttons for these in the first PR, if it is not going to take much longer.

In the footer of omise, there are links to Twitter and GitHub repositories, do you want to display these as well?

I think that's a good idea. What does everyone think?

yu23ki14 commented 1 year ago

Nengajo

It would be nice to display 15~20 new registered Nengajo in home page and also create Nengajo Page for display all Nengajo.

We need to create my page for display holding Nengajo, so adding something like a "Mypage" is nice

alecrem commented 1 year ago

It would be nice to display 15~20 new registered Nengajo in home page and also create Nengajo Page for display all Nengajo.

@yu23ki14 What else do we display on the home page? It could be confusing to show almost the same content on two different pages. We probably want paging when there are enough nengajos, anyway, so the first page shouldn't be too much anyway.

We need to create my page for display holding Nengajo, so adding something like a "Mypage" is nice

Sounds great! Thank you, we forgot about this page... How do we call it? Collection?

yu23ki14 commented 1 year ago

What else do we display on the home page?

I think showing mint opening hour is required, cuz before new year nobody can mint Nengajo, it could be looks good like count down timer. And also we can set closing hour (it could be Feb) if it is needed. In contract we implemented that function.

How to register and how to mint is also user friendly, but we can do that in Notion too.

imaichiyyy commented 1 year ago

@alecrem Thank you for your comment. I will take "omise" as a reference.

The "i18n" function is not so difficult to develop, so we will it. However, "Light / Dark mode" seems to be a low-priority feature, so I'll just display the button for now.

imaichiyyy commented 1 year ago

@alecrem @yu23ki14

Thank you for your comment. In summary, the menu items are as follows?

Home

Nengajo

Collection

(Which of the following?)

Register