search

henkelis / sonospy

Sonospy is a UPnP control point and Windows Media proxy for the Sonos multi-room audio system.
GNU General Public License v3.0
113 stars 16 forks source link

.m4a extension ignored by scan #44

Closed ianmacd closed 13 years ago

ianmacd commented 13 years ago

From scan.ini:

file_name_exclusions=.ds_store,desktop.ini,thumbs.db
file_extension_exclusions=.txt,.csv,.jpg,.png,.gif,.ffp,.md5

but scan still ignores .m4a files, which are just AACs:

$ file /media/audio/agnes_obel/itunes/riverside_single_remix/01_riverside_lulu_rouge_remix.m4a
/media/audio/agnes_obel/itunes/riverside_single_remix/01_riverside_lulu_rouge_remix.m4a: ISO Media, MPEG v4 system, iTunes AAC-LC

From scanlogverbose.txt:

Filetype not catered for: /media/audio/agnes_obel/itunes/riverside_single_remix/01_riverside_lulu_rouge_remix.m4a

I'm not an iTunes user, but this is a shows-topper for those who are.

ianmacd commented 13 years ago

gettags.py has code for handling MP4 files, but it's commented out. Why?

If I uncomment it and scan, I can add .m4a files to the DB, queue and play them, so I'm curious why the scanning code for them has been disabled.

henkelis commented 13 years ago

If only I could remember. It probably relates to using Easy vs not, though it may be that it broke something else. Or maybe I did it and forgot to put it back in :o)

I'll have to investigate unless someone wants to do testing of all file types concurrently.

On 08/14/2011 09:31 AM, ianmacd wrote:

scan.py has code for handling MP4 files, but it's commented out. Why?

If I uncomment it and scan, I can add .m4a files to the DB, queue and play them, so I'm curious why the scanning code for them has been disabled.

ianmacd commented 13 years ago

I've just done a full 81000+ file scan and all looks well.

Mind if I commit the change, so that others can see how it fares for them?

henkelis commented 13 years ago

That's fine. It may have related to comments, I had to find a way to propagate them through, and the Mutagen Easy module didn't allow that. We needed them then for virtuals and now we don't, so all may be well.

On 08/14/2011 11:43 AM, ianmacd wrote:

I've just done a full 81000+ file scan and all looks well.

Mind if I commit the change, so that others can see how it fares for them?

ianmacd commented 13 years ago

Many thanks. Pushing now.

It feels nice to fix an issue, even if I'm using your code to do it. :-)

Fixed in commit 41357b231a5c2fef6216f8a03ac9b18c38fa8c18.

henkelis commented 13 years ago

Does album art work for .m4a?

On 08/14/2011 03:53 PM, ianmacd wrote:

Many thanks. Pushing now.

It feels nice to fix an issue, even if I'm using your code to do it. :-)

Fixed in commit 91e8d5e50e57e7e01e270a6322d4b9eba1f26a0a.

ianmacd commented 13 years ago

Yep. You did a fine job. :-)