search

henkelis / sonospy

Sonospy is a UPnP control point and Windows Media proxy for the Sonos multi-room audio system.
GNU General Public License v3.0
113 stars 16 forks source link

Depend on web2py rather than bundling it (so it can be easily upgraded) #59

Open michaelnt opened 13 years ago

michaelnt commented 13 years ago

Issue #54 requires web2py to be upgraded, currently that is difficult to do because the sonos application is inside the web2py directory.

This change allows web2py to be installed via pip or in another directory, it needs a command to be run to create a file called VERSION which is pretty horrible but that is a problem with web2py.

I don't think the admin application is used so I removed it.

ianmacd commented 13 years ago

Mark? Comments?

henkelis commented 13 years ago

I'm OK with moving the app out of the web2py apps folder, and the removal of the admin app. I left the admin app in as at the time the sonospy app wouldn't work without it.

However, it appears that Michael has introduced other dependencies as a consequence - certainly virtualenv and pip are not installed by default in my version of Python so I'm not sure how best to install web2py and where. Also I'm not sure what w2p_apps is.

Finally, when you install web2py you get the admin app (and examples and welcome apps) installed - are they installed via pip?

ianmacd commented 13 years ago

Given that the code is supposed to run on NASes, we need to tread carefully when it comes to introducing new dependencies and making the installation more complicated.

michaelnt commented 13 years ago

virtualenv allows you to create an isolated python to install packages to, rather than installing them system wide, so its a good idea for developers to use.

pip is an improved easy_install, unfortunately easy_install fails to install web2py for some reason.

Anyway I've simplified things with this latest commit so there is no need to use virtualenv or pip.

henkelis commented 13 years ago

---- michaelnt reply@reply.github.com wrote:

virtualenv allows you to create an isolated python to install packages to, rather than installing them system wide, so its a good idea for developers to use.

Yes I agree it's great for us, just probably not end users.

pip is an improved easy_install, unfortunately easy_install fails to install web2py for some reason.

They claim web2py doesn't need installing. I did notice some install type scripts in their scripts folder.

Anyway I've simplified things with this latest commit so there is no need to use virtualenv or pip.

Reply to this email directly or view it on GitHub: https://github.com/henkelis/sonospy/pull/59#issuecomment-2011523

michaelnt commented 13 years ago

Once the dependencies are split out and the config, ini file and logging sorted out it should be possible to build a deb and have apt pull in the dependencies.

Alternatively could create a release script to create a tar file that includes all the dependencies.

ianmacd commented 13 years ago

debs and rpms are on the to-do list somewhere.

Something more basic will be needed for NAS installs.

michaelnt commented 13 years ago

Updated the README and tested some more, turns out the directory containing the controller modules needs to be on the python path for web2py to be able to import it. python setup.py develop provides an easy way to do that.