search

henkelmax / audio-player

Put your own audio files on music discs!
58 stars 21 forks source link

play command doesn't have a way to stop it #56

Closed ShiftySpace closed 12 months ago

ShiftySpace commented 1 year ago

Bug description Thank you so much for adding the play command to the audio player, been very great to have. The only issue is there's now no way to stop the sound from playing besides waiting for the audio to end.

Steps to reproduce the issue ex: /audioplayer play (sound id) x y z 10 There is now no way to stop the sound

Expected behavior Minecraft has the /stopsound command, it could work similar to that. I'd expect something like /audioplayer stop (sound id) and it would stop the nearest sound with that id. And or /audioplayer stop (sound id) x y z to stop it playing from the specified coordinates.

Versions

ShiftySpace commented 1 year ago

There's also no way to adjust the volume of the played sound much like you can change the volume of the goat horns and music discs in simple voice chat's adjust volume, you cannot do the same for the commands. I don't think it necessarily needs it's own setting, I don't think anyone would care if you just tied it to the music disc's volume.

ShiftySpace commented 1 year ago

Accidentally closed the issue.

Realized you can change the volume with the "other" category in game. So that is resolved.

If you allow the code I put in the pull request this issue is fixed.

SmajloSlovakian commented 12 months ago

i made another pull request, which repairs/updates the ShiftySpace's code so it works now... can you please check it out?

henkelmax commented 12 months ago

Closed with #66