search

henkelmax / audio-player

Put your own audio files on music discs!
58 stars 20 forks source link

Add stop command #66

Closed SmajloSlovakian closed 10 months ago

SmajloSlovakian commented 10 months ago

i just modified https://github.com/henkelmax/audio-player/pull/57 so it works as the original pull request was inactive

ShiftySpace commented 10 months ago

Dang @SmajloSlovakian thanks a lot! I am still pretty new to coding and also haven't had the time to figure out how I'd need to modify it for the newer versions. Did me a huge favor :D

SmajloSlovakian commented 10 months ago

i'm very new as well... sometimes you just need a clear mind to look at it

SmajloSlovakian commented 10 months ago

oh wow how do i approve everything... i clicked on view reviewed changes and checked that i viewed the files and clicked on review changes but i can't approve? do i really have to just make the same changes you proposed and commit them to my fork manually?

SmajloSlovakian commented 10 months ago

ohh i see how this works... i have to do that because you didn't like edit my code and submit it to me to approve it or somehting... ok... will look at it tomorrow

henkelmax commented 10 months ago

Thank you very much for your contribution!