search

henkelmax / easy-villagers

Never get annoyed by villagers again!
59 stars 26 forks source link

Iron Farms in chests - Bookbanning Issue with Carryon #126

Closed Vuulfrin closed 2 years ago

Vuulfrin commented 2 years ago

Bug description My server has both Easy Villagers and Carryon. Upon attempting to pickup a chest full of iron farms, I was immediately disconnected from my server and I knew right away what had happened. I do not have a screenshot of the issue, unfortunately. However, the error stated clearly the limit on the size of data contained within the chest was just slightly above the allowed limit. (By a very small margin)

While I suspect this issue would not have occurred, if say, Easy Villagers was the only mod installed and I had instead filled a shulker with iron farms, I have not tested this.

Some things to note are that the iron farms contained modded villagers, from Pokecube, which likely contributed to the issue. Pokecube villagers contain more data than vanilla npcs.

Steps to reproduce the issue

  1. Fill a shulker with iron farms that each contain a villager.
  2. Attempt to pick up the shulker in your inventory
  3. If one shulker full of iron farms containing vanilla villagers is not enough to bookban yourself, try adding more such shulkers to your inventory, or use villagers from a different mod, such as pokecube, to fill the iron farms
  4. If you are successful, you will be immediately booted from your world and will no longer be able to join.

Expected behavior Carryon is a mod that allows player to pick up tile entites such as chests, hopper, and even Easy Villager traders without breaking them. I expected to be able to carry the chest without issue.

Log files The log files do not appear any different from a normal disconnect, either server or client side. It is unfortunate that I did not think to take a screenshot of the error message at the time, but the message stated something to the effect of: "The max size of Y is X, but Y was larger than X"

Versions

Other mods Carryon was being used to pick up the chest without breaking it. The iron farms contained modded pokecube villagers.

henkelmax commented 2 years ago

Theres not much I can do about that. I can't reduce the size of the blocks. So you just have to be cautious with picking up container blocks containing a lot of items from this mod.