henkelmax / easy-villagers

Never get annoyed by villagers again!
59 stars 26 forks source link

[1.21] Still crashing when rendering trader block tooltip #222

Closed JaisDK closed 3 months ago

JaisDK commented 3 months ago

Bug description

https://github.com/henkelmax/easy-villagers/issues/219

same as the other one but with Artifacts now, this is something you need to fix on your end

Minecraft version

1.21

Mod version

1.21-1.1.15

Mod loader and version

NeoForge: 21.0.146

Steps to reproduce

https://mclo.gs/PwD33tL

Expected behavior

No response

Log files

https://mclo.gs/PwD33tL

Screenshots

No response

henkelmax commented 3 months ago

I am not able to reproduce this issue. I installed Artifacts and everything works perfectly fine. A can look at the tooltip of the trader block and it works fine.

JaisDK commented 3 months ago

You can't seriously expect all other mods to add a null check for a value that specifically should never be null. You're the one doing it wrong and should be fixing it.

henkelmax commented 3 months ago

As I said. I am not able to reproduce the issue you are having. Please add proper steps to reproduce. I can't fix the issue if im not getting it.

henkelmax commented 3 months ago

Could the issue have been fixed by #228?