search

henkelmax / easy-villagers

Never get annoyed by villagers again!
59 stars 26 forks source link

Regenerating Chunks While Trading #51

Closed ghost closed 3 years ago

ghost commented 3 years ago

Bug description While trading with a villager in the trader block, "waiting for server" will appear in the one probe and doesn't seem to go away. Seems to occur after naming the villager and taking them out and putting them back in the trading block a few times. Logging out and back in after the waiting message causes the chunk the trader was in to regenerate, losing everything placed/mined in the chunk.

(Delivery Inc Modpack)

Steps to reproduce the issue

  1. Get a trader block, profession block (composter) and a villager
  2. Trade with villager to lock in profession
  3. Take villager out of trader and name in an anvil (was my method to keep track of who had what trades)
  4. Put villager back in to trader and trade again, until the trades you have are exhausted
  5. Take the villager out of the trader and put in a chest. (usually to be replaced by another villager without exhausted trades)
  6. Take original villager back out of the chest, put back in trader and once trades reset, continue trading
  7. Notice that brackets have been added to the villagers name, they seem to compound each cycle of in/out.
  8. Repeat 4-7 ad nauseum. By the time we are in the right area, the villager has 4-5 sets of brackets around its name.
  9. Continue trading until the one probe indicates "Waiting for Server" (this is singleplayer). Message doesn't seem to go away by waiting
  10. Log out, Log back in
  11. Chunk has regenerated, everything inside is lost.
  12. Here's an (unlisted) video https://youtu.be/3CVcra-VM5k

Expected behavior Chunks not to regenerate.

Log files Debug https://gist.github.com/47MarkIV/9f0cf7143110156e5836d36b704c8227 Latest https://gist.github.com/47MarkIV/a6d57e365cffd442da79646671f1e4aa

Versions

Other mods

Tested with only Forge, JEI and Easy Villagers and was able to reproduce, same mod version numbers as the pack.

Pack Mods architectury-1.10.139-forge.jar AutoRegLib-1.6-47.jar BetterCaves-Forge-1.16.4-1.1.1.jar BetterMineshafts-Forge-1.16.4-2.0.3.jar BetterTitleScreen-1.16.4-1.10.2.jar Bookshelf-1.16.5-10.0.7.jar BotanyPots-1.16.5-7.0.10.jar BotanyTrees-1.16.5-3.0.2.jar buildinggadgets-1.16.5-3.8.0.jar byg-1.1.14.jar camera-1.16.5-1.0.10.jar cc-tweaked-1.16.4-1.95.3.jar chiselsandbits-0.3.4-RELEASE.jar chunkloaders-1.1.6-mc1.16.5.jar ClickMachine-1.16.4-4.3.0.jar cloth-config-4.11.18-forge.jar Clumps-6.0.0.17.jar CobbleForDays-1.3.1.jar CodeChickenLib-1.16.4-3.5.1.408-universal.jar cofh_core-1.16.4-1.2.1.jar compactmachines-4.0.0-beta.2.jar Compressium-1.16.5-1.2.2.jar corpse-1.16.5-1.0.1.jar CraftTweaker-1.16.5-7.1.0.179.jar Cucumber-1.16.4-4.1.9.jar curios-forge-1.16.5-4.0.5.0.jar DarkUtilities-1.16.5-8.0.3.jar DefaultOptions_1.16.3-12.2.0.jar delivery-1.16.5-1.0.38.jar easy_villagers-1.16.5-1.0.6.jar EnderStorage-1.16.4-2.7.1.166-universal.jar extradisks-1.16.4-1.5.0.jar ExtraStorage-1.16.4-1.3.1.jar extremeSoundMuffler-3.9_Forge-1.16.5.jar ftb-backups-2.1.1.6.jar ftb-chunks-1605.2.3-build.75.jar ftb-gui-library-1605.2.1.41-forge.jar immersive-portals-0.16-mc1.16.5-forge.jar industrial-foregoing-1.16.5-3.2.10.2-d316328.jar InitialInventory-5.0.1.11.jar ironchest-1.16.4-11.2.10.jar JAOPCA-1.16.5-3.4.0.7.jar jei-1.16.5-7.6.1.75.jar JEITweaker-1.16.5-1.0.1.14.jar JustEnoughResources-1.16.3-0.12.0.100.jar light-overlay-5.8.0.jar mcjtylib-1.16-5.0.19.jar Mekanism-1.16.5-10.0.21.448.jar MekanismAdditions-1.16.5-10.0.21.448.jar MekanismGenerators-1.16.5-10.0.21.448.jar MekanismTools-1.16.5-10.0.21.448.jar morevanillalib-1.16.4-1.4.0.jar Morph-o-Tool-1.4-27.jar MouseTweaks-2.14-mc1.16.2.jar MysticalAgradditions-1.16.4-4.1.5.jar MysticalAgriculture-1.16.4-4.1.7.jar MysticalCustomization-1.16.4-2.1.3.jar NaturesCompass-1.16.5-1.8.6.jar PackMenu-1.16.4-2.4.0.jar Patchouli-1.16.4-50.jar pipez-1.16.5-1.1.2.jar Placebo-1.16.4-4.4.1.jar pneumaticcraft-repressurized-1.16.5-2.11.4-170.jar prefab-1.6.5.0.jar QuantumStorage-1.16.4-5.3.0.jar Quark-r2.4-309.jar refinedstorage-1.9.12.jar refinedstorageaddons-0.7.2.jar ResourcefulBees-1.16.5-0.6.5b.jar rftoolsbase-1.16-2.0.10.jar rftoolsbuilder-1.16-3.0.16.jar rftoolsutility-1.16-3.0.25.jar rsrequestify-1.16.3-2.0.1.jar Runelic-1.16.5-7.0.1.jar serverconfigupdater-1.3.jar shutupexperimentalsettings-1.0.3.jar sleeping_bags-1.16.5-1.0.1.jar SolarFluxReborn-1.16.3-16.2.3.jar sophisticatedbackpacks-1.16.4-2.2.8.232.jar Storage4ComputerCraft-1.16.4-1.2.2.jar StorageDrawers-1.16.3-8.2.2.jar supermartijn642configlib-1.0.5a-mc1.16.jar theoneprobe-1.16-3.0.7.jar thermal_expansion-1.16.4-1.2.0.jar thermal_foundation-1.16.4-1.2.0.jar titanium-1.16.5-3.2.8.1.jar torchmaster-2.3.6.jar trashcans-1.0.8-mc1.16.4.jar vanillahammers-1.16.4-2.2.0.jar Waystones_1.16.5-7.4.0.jar YungsApi-1.16.4-Forge-4.jar AkashicTome-1.4-16.jar angelring-1.16.3-1.3.3.jar antimobgriefing-1.16.5-1.0.2.jar

Screenshots (Optional) Video https://youtu.be/3CVcra-VM5k

henkelmax commented 3 years ago

Thank you for reporting this issue! It seems that this chunk issue is related to the villager name. Can you test it with version 1.0.7?

ghost commented 3 years ago

Tested in 1.0.7 and everything looks to be fixed! Thank you so much :)

henkelmax commented 3 years ago

No problem!