search

henkelmax / gravestone

Places a gravestone with your inventory items inside when you die.
21 stars 35 forks source link

backported sneak pickup feature to 1.7.10 #100

Closed facetorched closed 2 years ago

facetorched commented 2 years ago

This feature from future versions is great and I would love to have this merged and built into a release! I think players on 1.7.10 would appreciate it.

I tried to keep the code as similar to the future implementation while respecting the rest of the code in this version as to (hopefully) not introduce any bugs. Of course some re-factoring could be done to make the overall code cleaner, but I decided against modifying existing classes as much as possible.

henkelmax commented 2 years ago

Sorry, but this version is unsupported for a couple of years now. I can't even get the workspace running anymore.

facetorched commented 2 years ago

@henkelmax ah understandable. I am able to get it running with a new buildscript. I could create a PR for that but it sounds like you are unwilling to accept contributions for this version.

That said, given there is no license for this project, how flexible would you be for me to pick up support for this old version of the game? e.g. distributing releases etc.

henkelmax commented 2 years ago

This version is over 8 years old. I don't have the time to put any work into this. I'm sorry.

facetorched commented 2 years ago

No problem I just want to be respectful of your work. I take it that you have no issues with me continuing development? I will of course credit you and the other original developers

henkelmax commented 2 years ago

As long as you don't release the mod on any mod distribution pages (Like CurseForge or modrinth), thats fine for me.

facetorched commented 2 years ago

Hm. That's too bad since I'd like to be able to have these fixes on a public modpack and server. Well I guess this is what I get for not asking first! does github count as a mod distribution page? I could post a release on my fork.

henkelmax commented 2 years ago

I can't release old versions on CurseForge, since their file promotion is completely broken. If a 1.7.10 file would be the latest uploaded file, the whole project would get tagged as 1.7.10 and a lot of other issues.

does github count as a mod distribution page? I could post a release on my fork.

That would be fine.