henkelmax / gravestone

Places a gravestone with your inventory items inside when you die.
16 stars 33 forks source link

Grave generates above death location in next available free space, potentially all the way on the surface if killed in confined area #150

Closed Voltem0 closed 11 months ago

Voltem0 commented 11 months ago

Bug description When Dying underground, in some cases the gravestone will instead appear on the surface, needing a dedicated search to find it rather than just going to the spot where the player died. The moratorium shows the death coordinates, but not the coordinates where the gravestone spawned making the recovery very cumbersome.

Steps to reproduce the issue 1) Go underground into a tight corridor (1 block wide, 2 blocks high) with no adjacent caves or hollow spaces. above spaces and caves are fine so long as there is at least 5 blocks to showcase the issue. 2) die, either by mob or /kill command 3) done

Expected behavior The mod generates the gravestone above the actual death location in the next available space. this can be either a random cave or on the surface, even if the player died a hundred blocks underground.

log files https://gist.github.com/Voltem0/986def8ce00990163f54eb4c108c666d

Versions

Other mods Now i noticed this issue as part of a modpack, but it occurs consistently with only the gravestones mod alone.

Voltem0 commented 10 months ago

"works as intended"? how the heck is this an intended feature? If i die while underground i at least know how i got there, if the gravestone spawns on the surface in a forest i have to check underground first, then discover it is not there only to have to search for it above ground! the whole point of the mod is to leave a grave marker on the location where the player died, not miles above it! Why would you mark this as 'Works as intended' and close the thread?!

henkelmax commented 10 months ago

From https://legacy.curseforge.com/minecraft/mc-mods/gravestone-mod:

image

It always has been like that. It is clearly stated on the mod page that it works like this.

Voltem0 commented 10 months ago

I assumed this line was for if you are trapped in gravel or sand and there are no free spaces on your location, not that the grave always needed a free block above the character's head to work. After all, the grave does not usually generate above the character's head-level but on the ground. Neither are 2-block tall strip-mines something unusual in minecraft. I would make sense if the grave spawns on your feet and then goes higher only if it finds that space occupied.

But alright, bit confused as to why this is the intended way but fair enough.

Edit: As a side-note, should the mortuary note not be adjusted to tell the spawning location of the grave instead of the death location in case the two do not lign up? I was unpleasantly suprised despite reading the mod description and i doubt i am the only one this happened to