search

henkelmax / pipez

Lag friendly pipes.
44 stars 24 forks source link

Items getting voided when pulling from functional storage armory cabinet with no room in destination #177

Closed MindCaged closed 1 year ago

MindCaged commented 1 year ago

Please read the FAQ before submitting a bug report!

Bug description A clear and concise description of what the bug is. I'm playing ATM8 and dumped all the non-stackable tools/armor into a functional storage armory cabinet. I am then using the nbt tag filtering on pipez to extract all the apotheosis affix items and the enchanted items so I can disenchant them and salvage the affix items for rarity materials. In the process I twice had an incident where almost all the items were voided because the destination chest was full and I had to reload a backup. This does not happen when pulling from ordinary chests or sophisticated storage chests so it may be a bug with functional storage, though I have tested with other item transport mods including laserio and mekanism and they both behave as expected.

Steps to reproduce the issue Place a functional storage armory cabinet, put a pipez pipe on it set to extract, use an addon so you can switch it to run with redstone and put a lever down next to it,, put a chest on the destination side and fill all slots with cobblestone or something. Use a hopper to put a pickaxe or other non-stackable tool into the armory cabinet. If you have one-probe and set it to show extra info you can use it to see the pickaxe is now in the cabinet. Flip the lever to on. The pickaxe is no longer in the cabinet and it's not in the destination chest either. It's just gone.

Expected behavior The item should still be in the armory cabinet if there's no room in the destination, I can only assume the cabinet thinks the item has been successfully pulled out and deletes it from it's inventory.

Log files Nothing shows up in the logs.

Versions

Other mods A list of the other mods that were installed when this problem occurred. All The Mods 8 pack It would be ideal if you could test if this problem persists when no other mod is installed. If not, please narrow down the mod(s) that are causing the problem. Okay, tried making a new instance with just jei, titanium, pipez, and functional storage and it has the same problem. I forgot to install one probe so it was a bit hard to determine if the pickaxe was still in there. I used a hopper on the bottom with a lever to check it the pickaxe was gone.

Screenshots (Optional) Screenshots of the issue. N/A

Th3Fanbus commented 1 year ago

Also had issues with the Functional Storage Armory Cabinet on ATM8, same mod versions. It seems to be a bug in Functional Storage, given that AE2 complained about the Armory Cabinet when trying to use it via a Storage Bus:

    [13Apr2023 22:25:17.380] [Server thread/WARN] [AE2:S/]: Mod that provided item handler com.buuz135.functionalstorage.block.tile.ArmoryCabinetTile$1 is broken. Returned 3 potion items while only requesting 1.
    [13Apr2023 22:25:17.381] [Server thread/WARN] [AE2:S/]: Mod that provided item handler com.buuz135.functionalstorage.block.tile.ArmoryCabinetTile$1 is broken. Returned 3 potion items while only requesting 1.
    [13Apr2023 22:25:45.702] [Server thread/WARN] [AE2:S/]: Mod that provided item handler com.buuz135.functionalstorage.block.tile.ArmoryCabinetTile$1 is broken. Returned 4 potion items while only requesting 1.
    [13Apr2023 22:25:45.702] [Server thread/WARN] [AE2:S/]: Mod that provided item handler com.buuz135.functionalstorage.block.tile.ArmoryCabinetTile$1 is broken. Returned 4 potion items while only requesting 1.
    [13Apr2023 22:26:01.239] [Server thread/WARN] [AE2:S/]: Mod that provided item handler com.buuz135.functionalstorage.block.tile.ArmoryCabinetTile$1 is broken. Returned 3 leather_leggings items while only requesting 1.
    [13Apr2023 22:26:01.239] [Server thread/WARN] [AE2:S/]: Mod that provided item handler com.buuz135.functionalstorage.block.tile.ArmoryCabinetTile$1 is broken. Returned 3 leather_leggings items while only requesting 1.
    [13Apr2023 22:26:02.989] [Server thread/WARN] [AE2:S/]: Mod that provided item handler com.buuz135.functionalstorage.block.tile.ArmoryCabinetTile$1 is broken. Returned 2 leather_leggings items while only requesting 1.
    [13Apr2023 22:26:02.989] [Server thread/WARN] [AE2:S/]: Mod that provided item handler com.buuz135.functionalstorage.block.tile.ArmoryCabinetTile$1 is broken. Returned 2 leather_leggings items while only requesting 1.
    [13Apr2023 22:26:04.083] [Server thread/WARN] [AE2:S/]: Mod that provided item handler com.buuz135.functionalstorage.block.tile.ArmoryCabinetTile$1 is broken. Returned 2 leather_boots items while only requesting 1.
    [13Apr2023 22:26:04.083] [Server thread/WARN] [AE2:S/]: Mod that provided item handler com.buuz135.functionalstorage.block.tile.ArmoryCabinetTile$1 is broken. Returned 2 leather_boots items while only requesting 1.
    [13Apr2023 22:26:10.131] [Server thread/WARN] [AE2:S/]: Mod that provided item handler com.buuz135.functionalstorage.block.tile.ArmoryCabinetTile$1 is broken. Returned 2 leather_boots items while only requesting 1.
    [13Apr2023 22:26:10.132] [Server thread/WARN] [AE2:S/]: Mod that provided item handler com.buuz135.functionalstorage.block.tile.ArmoryCabinetTile$1 is broken. Returned 2 leather_boots items while only requesting 1.

This happened when trying to take out unstackable items (potions, leather armor pieces) stored in the Armory Cabinet via an AE2 ME Terminal, of which there were more than one.

MindCaged commented 1 year ago

Hmm, I wondered if it might be functional storage since it didn't happen with normal inventories. But again like I said in the first post laserio and mekanism both worked correctly so maybe it's some combination, I'll open a ticket on functional storage though.

Edit: Apparently somebody beat me to it 2 1/2 months ago, but no response on the thread.