henkelmax / pipez

Lag friendly pipes.
44 stars 24 forks source link

Item pipez not obeying slot limits #178

Closed Hekera closed 1 year ago

Hekera commented 1 year ago

Please read the FAQ before submitting a bug report!

Bug description Certain blocks, like the logistical item buffer from Thermal Dynamics, can limit the number of items each slot accepts to a number below the max stack size for the item. Item pipez do not obey this limit and send the max amount of items per transfer. For example, if the pipe transfers 32 paper every 5 ticks, but the logistical item buffer has a max of 3 paper, the pipe will send 32 paper anyway. View the item buffer code here: https://github.com/CoFH/ThermalDynamics/blob/1.19.x-dev/src/main/java/cofh/thermal/dynamics/block/entity/ItemBufferBlockEntity.java

Steps to reproduce the issue

  1. Configure a logistical item buffer such that it is in latching mode with a low maximum for items in each slot.
  2. Use item pipez to transfer items into the buffer.
  3. Open the item buffer menu to see that it has more items than it should.
  4. Optionally test with methods of item transport from other mods (such as laser IO) and observe that they interact properly with the buffer.

Expected behavior For the example above, the expected behavior would be for at most 3 paper to be transferred by the pipe, depending on how much paper is already in the slot.

Log files This bug was reported by a user on the CoFH discord who did not provide any logs.

Versions

Other mods Unknown, user did not provide.

Screenshots (Optional) image image

henkelmax commented 1 year ago

Not a Pipez issue. https://github.com/CoFH/CoFHCore/pull/39