search

henkelmax / simple-voice-chat

A working voice chat in Minecraft!
https://modrepo.de/minecraft/voicechat/wiki
455 stars 112 forks source link

1.19.3 PlayerEntryMixin Inject is broken and crashes the game #503

Closed mjwells2002 closed 1 year ago

mjwells2002 commented 1 year ago

Bug description

In latest 1.19.3 release (1.19.3-2.3.21) the PlayerEntryMixin is broken, this issue was originally reported as a bug in memory leak fix here, https://github.com/fxmorin/MemoryLeakFix/issues/61

Steps to reproduce the issue

Load voicechat, join a server with other users open player reporting screen or social interactions screen, the game will crash

OR

Use a mod that forces early inject of mixins (IE memory leak fix) alongside voicechat, and the game will crash on startup

Expected behavior

The mixin should inject, and not fail

Log files

Provided only for the sake of completness not really relevent here https://mclo.gs/v2JUM3F

Versions

Other mods

As mentioned issue will happen instantly with mods that force early mixin injects, but also happens with no other mods

mjwells2002 commented 1 year ago

This also happens in quit both are fixed in commit https://github.com/henkelmax/simple-voice-chat/commit/f26db3f75e80ea6b4ed508666c763c9a9e07ac0b not closing this issue until released @henkelmax