henkelmax / simple-voice-chat

A working voice chat in Minecraft!
https://modrepo.de/minecraft/voicechat/wiki
426 stars 106 forks source link

viaversion dependecy has incompatibility with kyrpton #603

Closed sean-7777 closed 1 year ago

sean-7777 commented 1 year ago

Please read the wiki before submitting a bug report!

Bug description basically this thing needs viaversion. thats fine but viaversion doesnt work with krypton as you can see here astei/krypton#12 and ViaVersion/ViaFabric#89

Steps to reproduce the issue

  1. install viafabric
  2. install krypton
  3. install simple voice chat
  4. see error

Expected behavior no error

Log files see this: https://ambigious.hypixel.pro/e3k411k9svj5vhr8xa.png

Versions

Other mods im pretty sure its not becuase of other mod

Screenshots (Optional) none

henkelmax commented 1 year ago

This is a soft dependency:

https://github.com/henkelmax/simple-voice-chat/blob/1.20.1/fabric/src/main/resources/fabric.mod.json#L39-L43

image image

For bukkit aswell:

https://github.com/henkelmax/simple-voice-chat/blob/999436b9b067500794b299775784f73341733e24/bukkit/src/main/resources/plugin.yml#L23

But even if this would be a hard dependency, this seems to be a krypton issue. So we won't change anything here.