henkelmax / simple-voice-chat

A working voice chat in Minecraft!
https://modrepo.de/minecraft/voicechat/wiki
426 stars 106 forks source link

PTT & whisper keys handled incorrectly #604

Closed isXander closed 1 year ago

isXander commented 1 year ago

Bug description The afformentioned binds are handled inside of a keyboard event. This is incorrect. Usually, mods handle this inside the game tick, which you have done for all other binds. This is an issue for me as it breaks compatibility with mods that emulate key presses. Namely, my mod, Controlify. This prevents the use of controller bindings on SVC as no key event is actually invoked.

Steps to reproduce the issue

  1. Install Controlify with SVC
  2. Bind PTT or whisper
  3. Attempt to use

Expected behavior PTT and whisper should be handled like all other keybinds so they work correctly.

Versions

henkelmax commented 1 year ago

This is done on purpose, as these keys need to work globally. This means, it has to work, when Minecraft key input events are blocked, like when you are in a text box.