henkelmax / simple-voice-chat

A working voice chat in Minecraft!
https://modrepo.de/minecraft/voicechat/wiki
426 stars 106 forks source link

Polymer + Velocity breaks Voicechat #615

Closed Dev0Louis closed 11 months ago

Dev0Louis commented 11 months ago

Please read the wiki before submitting a bug report!

Bug description When Simple Voicechat are installed together, Voicechat behaves weird. Connections do not work 99% of the time

Steps to reproduce the issue

  1. Install Velocity and a Server with these Mods
  2. Join the Server.
  3. Leave the Server.
  4. Join the Server.
  5. No Voicechat connection.

Expected behavior Everything should connect and work.

Log files Client. Server

Versions

Other mods Fabric API, Proxy Lite, Polymer

henkelmax commented 11 months ago

Does this only happen with velocity?

Dev0Louis commented 11 months ago

Yes, at least never observed it without it.

henkelmax commented 11 months ago

I tried to reproduce your issue and managed to get this to happen without a proxy. It also happens with just

and the voice chat mod.

henkelmax commented 11 months ago

I made a fix that makes voice chat work with polymer, but the root cause seems to be polymer causing fabrics ClientPlayConnectionEvents.JOIN event to be called twice on login (Once on login and a second time when the resource pack finished loading). You should also report this issue to polymer.

Patbox commented 11 months ago

From technical view, it's not "fixable" on my side either, through the same behavior can be seen with proxies like velocity. I need to send first one to initialize player for velocity/resource pack sending and second one is the vanilla one

henkelmax commented 11 months ago

From technical view, it's not "fixable" on my side either, through the same behavior can be seen with proxies like velocity. I need to send first one to initialize player for velocity/resource pack sending and second one is the vanilla one

I fixed it on my side anyways. It might just be an issue for other mods that rely on that event being fired once.

Dev0Louis commented 11 months ago

The Issue is not solved. It still does not connect.

henkelmax commented 11 months ago

The Issue is not solved. It still does not connect.

It should now be properly fixed