henkelmax / simple-voice-chat

A working voice chat in Minecraft!
https://modrepo.de/minecraft/voicechat/wiki
457 stars 120 forks source link

My microphone works and sounds good when i click on test microphone but to others and in recordings it's horrible #727

Closed jojommeke closed 3 months ago

jojommeke commented 3 months ago

Confirmation

Bug description

config file:

# Simple Voice Chat client config v1.20.2-2.5.12

# If the voice chat onboarding process has been finished
onboarding_finished=true
# The voice chat volume
voice_chat_volume=1.0045454545454546
# The threshold for voice activation in dB
voice_activation_threshold=-45.311557788944725
# The voice chat microphone amplification
microphone_amplification=4.0
# Microphone activation type
# Possible values are 'PTT' and 'VOICE'
microphone_activation_type=VOICE
# The size of the audio output buffer in packets
# Higher values mean a higher latency, but less crackles
# Increase this value if you have an unstable internet connection
output_buffer_size=16
# The maximum amount of audio packets that are held back if a packet arrives out of order or gets dropped
# This prevents discarding audio packets that are slightly out of order
# Set this to 0 to disable
audio_packet_threshold=3
# The time it takes for the microphone to deactivate when using voice activation
# A value of 1 means 20 milliseconds, 2=40 ms, 3=60 ms, ...
voice_deactivation_delay=25
# The microphone used by the voice chat
# Empty for default device
microphone=Virtual Source
# The speaker used by the voice chat
# Empty for default device
speaker=Teufel RADIO ONE
# If the microphone is muted (only when using voice activation)
muted=false
# If the voice chat is disabled (sound and microphone off)
disabled=false
# If the voice chat icons should be hidden
hide_icons=false
# If the group HUD should be visible
show_group_hud=true
# If the own icon should be shown when in a group
show_own_group_icon=true
# The scale of the group HUD
group_hud_icon_scale=2.0
# The orientation of the player icons in the group HUD
# Possible values are 'VERTICAL' and 'HORIZONTAL'
group_player_icon_orientation=VERTICAL
# The X position of the player icons in the group HUD
# Negative values mean anchoring to the right
group_player_icon_pos_x=4
# The Y position of the player icons in the group HUD
# Negative values mean anchoring to the bottom
group_player_icon_pos_y=240
# The X position of the HUD icons
# Negative values mean anchoring to the right
hud_icon_pos_x=16
# The Y position of the HUD icons
# Negative values mean anchoring to the bottom
hud_icon_pos_y=-16
# The scale of the HUD icons
hud_icon_scale=1.0
# The location where recordings should be saved
# Leave empty for default location
recording_destination=
# The quality of the recorded audio
# 0 = highest quality, 9 = lowest quality
recording_quality=0
# If noise cancellation should be enabled
denoiser=true
# If voice chat should work in singleplayer/LAN worlds
run_local_server=false
# Whether to use the Java implementation of microphone capturing instead of OpenAL
java_microphone_implementation=true
# If the mod should check for microphone permissions (MacOS only)
macos_check_microphone_permission=true
# If fake players should have the disconnected icon above their head
show_fake_players_disconnected=false
# If the volume adjustment GUI should also show offline players
offline_player_volume_adjustment=true
# The 3D audio type
# Possible values are 'NORMAL', 'REDUCED' and 'OFF'
audio_type=NORMAL
# If the mod should load native libraries
# If set to false, the Java Opus implementation will be used, the denoiser won't be available and you won't be able to record audio.
use_natives=true
# How listening to other players should work when using freecam mods
# Possible values are 'CAMERA' and 'PLAYER'
# CAMERA: You will hear voice chat audio around your camera. Whether you hear distant audio depends on the voice chat broadcast range of the server
# PLAYER: You will hear voice chat audio around your player no matter where your camera is
freecam_mode=CAMERA
# If enabled, you will be automatically muted when joining a world
mute_on_join=false

(virtual source sounded better they said)

using latest version flatpak prismlauncher (error also occurs in non-flatpak prismlauncher) image image

Minecraft version

1.20.2

Mod/Plugin version

1.20.2-2.5.12

Mod/Plugin loader and version

see screenshot

Steps to reproduce

(issue happens in my server and in another server too so it's not server specific)

  1. have a steam deck and use it's internal mic
  2. test the mic online(good quality)
  3. test the mic in simple voice chat(good quality)
  4. have a friend join SVC group(they hear bad quality, you hear their mic perfectly fine)
  5. or record your own audio(also bad quality)

Expected behavior

the mic sounds the same for others as in the test mic option

Log files

https://gist.github.com/jojommeke/8e67b54be04775d5047425d17835b4c7

Screenshots

also in description

jojommeke commented 3 months ago

i think i kind of fixed it by using the non flatpak prismlauncher(appimage) and the config because now the recordings sound good but still it should work with flatpak

henkelmax commented 3 months ago

You are using an unsupported version of the mod.

As far as I know flatpak does sandbox the application and thus might cause issues. Thats why we generally don't support that. https://docs.flatpak.org/en/latest/sandbox-permissions.html

jojommeke commented 3 months ago

You are using an unsupported version of the mod.

As far as I know flatpak does sandbox the application and thus might cause issues. Thats why we generally don't support that. https://docs.flatpak.org/en/latest/sandbox-permissions.html

the microphone is detected and works fine even in simple voice chat preview microphone option, also why is the version i use unsupported?