Closed Greg-21 closed 1 month ago
I've answered all your questions and addressed any concerns you might have had, I hope. If there's a question with no answer, it means that the answer has already been given elsewhere. (If it is not and I have missed something, please let me know.)
Have a nice day!
I've answered all your questions and addressed any concerns you might have had, I hope. If there's a question with no answer, it means that the answer has already been given elsewhere. (If it is not and I have missed something, please let me know.)
Have a nice day!
I reviewed and answered all your comments :) Good job btw :) you are really taking the consistency to minecraft serious
We are getting closer and closer to the final result that both of us can be satisfied with, I hope.
I'm sorry that it's taking so long and that the progress since last time is minimal, but I'm only working on it in my spare time, making just a few changes each day.
We are getting closer and closer to the final result that both of us can be satisfied with, I hope.
I'm sorry that it's taking so long and that the progress since last time is minimal, but I'm only working on it in my spare time, making just a few changes each day.
No worries :) Let me know once its ready to review.
I've finished and published everything I had planned for this review cycle earlier today. If you find some time, you can check it out.
I've finished and published everything I had planned for this review cycle earlier today. If you find some time, you can check it out.
Will do thanks!
Alright, I think i've answered everything
Thank you for your patience. The good news is that there are only a few topics left that need your input.
Thanks, I think ive answered everything.
I have a few last review questions for you. Please take a look at them when you find some time.
I have a few last review questions for you. Please take a look at them when you find some time.
Done
This pull request is now ready for a final review or two. It’s been a long journey, and I really appreciate your help and time!
How do I dismiss a stale review now? ¯_(ツ)_/¯
Just ignore it. I'll do a final pass when I have time and merge it if I don't find anything.
I found 1 small thing again that I forgot to tell you about, sorry.
Thanks a lot!
If you have any suggestions or small things that you notice, you can add me on Discord, my name is henkelmax
.
I personally don't use Discord, but thanks for the invitation :)
First, a quick note that this pull request is technically a draft and will initially be labeled as such here on GitHub, so every single change can be freely discussed without any time pressure.
To simplify the review process, this pull request consists of three main parts (one commit for each part):
cloth_config.voicechat.category.other
translation key has been renamed tocloth_config.voicechat.category.ingame_menu
to better reflect the new value it now conveys.message.voicechat.enabled
andmessage.voicechat.disabled
have been renamed tomessage.voicechat.denoiser.on
andmessage.voicechat.denoiser.off
respectively to show the logical connection between them and the corresponding configuration option they define (i.e.message.voicechat.denoiser
). Additionally, this also replaces the long descriptive labels such as "enabled" and "disabled" with their shorter and generic equivalents: "ON" and "OFF".Please review these changes carefully, as the description above only summarizes the most significant ones, not all of them. I'm open to all kinds of criticism and comments because I realize that what seems like a positive change to me, may actually be the opposite. Furthermore, this is your mod, your repo, your rules (not mine), and I'm just trying to help as much as I can.