henkelmax / simple-voice-chat

A working voice chat in Minecraft!
https://modrepo.de/minecraft/voicechat/wiki
457 stars 120 forks source link

U.S. English translation revamp and cleanup of other lang files #736

Closed Greg-21 closed 1 month ago

Greg-21 commented 2 months ago

First, a quick note that this pull request is technically a draft and will initially be labeled as such here on GitHub, so every single change can be freely discussed without any time pressure.

To simplify the review process, this pull request consists of three main parts (one commit for each part):

  1. U.S. English translation revamp:
    • The focus here was put on rephrasing the sentences used in tooltips and in-game configuration menus in the hope of making them clearer and easier to understand (especially for people who are new to this fantastic mod and don’t know yet what each option does).
    • In addition, standardization of wording also played a significant role here because it happened that the same thing was called differently in different places.
    • Another thing worth noting is a capitalization of slider and button labels, and an addition of dots at the ends of sentences in tooltips for parity with vanilla Minecraft.
    • On top of that, the cloth_config.voicechat.category.other translation key has been renamed to cloth_config.voicechat.category.ingame_menu to better reflect the new value it now conveys.
    • Last but not least, the following two translation keys: message.voicechat.enabled and message.voicechat.disabled have been renamed to message.voicechat.denoiser.on and message.voicechat.denoiser.off respectively to show the logical connection between them and the corresponding configuration option they define (i.e. message.voicechat.denoiser). Additionally, this also replaces the long descriptive labels such as "enabled" and "disabled" with their shorter and generic equivalents: "ON" and "OFF".
  2. Configuration file comment revamp:
    • This mainly introduces the same changes as in the previous point so that not only people using the in-game configuration GUI based on the Cloth Config API could benefit from the improvements but also people configuring this mod directly via configuration files.
    • It also unifies the comments for various configuration options between different platforms/engines so that everyone is treated equally.
  3. Translation file cleanup:
    • This includes rearranging all lines so that they are in the same order as in the source U.S. English translation file, removing translation keys that are no longer in use, and unifying line endings to always use LF only.
    • Most of these changes were made automatically by a script I created, so the chance of error is minimal.

Please review these changes carefully, as the description above only summarizes the most significant ones, not all of them. I'm open to all kinds of criticism and comments because I realize that what seems like a positive change to me, may actually be the opposite. Furthermore, this is your mod, your repo, your rules (not mine), and I'm just trying to help as much as I can.

Greg-21 commented 2 months ago

I've answered all your questions and addressed any concerns you might have had, I hope. If there's a question with no answer, it means that the answer has already been given elsewhere. (If it is not and I have missed something, please let me know.)

Have a nice day!

henkelmax commented 2 months ago

I've answered all your questions and addressed any concerns you might have had, I hope. If there's a question with no answer, it means that the answer has already been given elsewhere. (If it is not and I have missed something, please let me know.)

Have a nice day!

I reviewed and answered all your comments :) Good job btw :) you are really taking the consistency to minecraft serious

Greg-21 commented 2 months ago

We are getting closer and closer to the final result that both of us can be satisfied with, I hope.

I'm sorry that it's taking so long and that the progress since last time is minimal, but I'm only working on it in my spare time, making just a few changes each day.

henkelmax commented 2 months ago

We are getting closer and closer to the final result that both of us can be satisfied with, I hope.

I'm sorry that it's taking so long and that the progress since last time is minimal, but I'm only working on it in my spare time, making just a few changes each day.

No worries :) Let me know once its ready to review.

Greg-21 commented 2 months ago

I've finished and published everything I had planned for this review cycle earlier today. If you find some time, you can check it out.

henkelmax commented 2 months ago

I've finished and published everything I had planned for this review cycle earlier today. If you find some time, you can check it out.

Will do thanks!

henkelmax commented 2 months ago

Alright, I think i've answered everything

Greg-21 commented 2 months ago

Thank you for your patience. The good news is that there are only a few topics left that need your input.

henkelmax commented 2 months ago

Thanks, I think ive answered everything.

Greg-21 commented 2 months ago

I have a few last review questions for you. Please take a look at them when you find some time.

henkelmax commented 1 month ago

I have a few last review questions for you. Please take a look at them when you find some time.

Done

Greg-21 commented 1 month ago

This pull request is now ready for a final review or two. It’s been a long journey, and I really appreciate your help and time!

henkelmax commented 1 month ago

How do I dismiss a stale review now? ¯_(ツ)_/¯

Just ignore it. I'll do a final pass when I have time and merge it if I don't find anything.

henkelmax commented 1 month ago

I found 1 small thing again that I forgot to tell you about, sorry.

henkelmax commented 1 month ago

Thanks a lot!

henkelmax commented 1 month ago

If you have any suggestions or small things that you notice, you can add me on Discord, my name is henkelmax.

Greg-21 commented 1 month ago

I personally don't use Discord, but thanks for the invitation :)