henkelmax / sound-physics-remastered

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
69 stars 22 forks source link

Underwater sounds not working correctly #149

Closed Thelegendking closed 6 months ago

Thelegendking commented 8 months ago

Bug description No sound from mobs under water.

Steps to reproduce the issue

  1. Go to near a lake, or ocean or anything that has alot of water
  2. Click on crouch to go inside water
  3. Hurt any monster inside the water
  4. You'll hear no sound

Expected behavior No or very very low sound from mob under water even if they are one block away.

Versions

Allexio commented 8 months ago

Because my issue got closed, here is what I wrote on my side for easy access here (since apparently this is the same issue): I personally do not hear ANY sound underwater unless I am directly touching the block I am hitting/destroying. I even tried setting underwater filter to 0

I am on 1.20.1 Fabric. Latest version of Fabric loader for 1.20.1. Mod version is also latest for 1.20.1 (1.2.1)

No other mods impact sound except for plasmovoice & presence footsteps.

Thelegendking commented 8 months ago

Same, I also tried setting underwater filter to 0 but nope it didn't fix. I only use this mod and presence footsteps for sounds.

DDunda commented 7 months ago

I want to add that I cannot hear any sounds even when standing waist deep in water. I have also tried turning the underwater filter to 0, and decreasing block absorption as well without improvement. I am on 1.2.1 for version 1.19.2, forge.

carefreeDesigner commented 7 months ago

As of 11/25/2023 this is still an issue. I'm on 1.20.1 on mod version 1.2.1. I've tried editing the underwater filter from 1.0 to 0.5 to 0.01 to 0.0 and none had any changes whatsoever. Any sound underwater is so quiet, if it's even there, that it might as well not exist. This also applies when the Player is in one block or water or swimming on the surface. Sounds like eating or entering/exiting the water are next to inaudible.

Here's my modlist, if it'll help fix this issue: https://pastebin.com/PYq04DDd

obj-obj commented 7 months ago

If you turn on "render sound bounces" in debug you can see the sound bouncing around within one water source block and never escaping the block. Seems like water is incorrectly marked as a solid block or something?