henkelmax / sound-physics-remastered

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
75 stars 24 forks source link

Funky Cavernous Sound Projection #153

Closed Peonovic closed 11 months ago

Peonovic commented 11 months ago

Bug description Various circumstances can cause sound to project absurd distances while sounding like you're inside a cave.

Steps to reproduce the issue

  1. Find or create a cave.
  2. Insert something that generates noise other than fluids (they do not seem to cause problems).
  3. Hover away while remaining in line with the cave.

Expected behavior Expected behavior is exhibited in videos 2 and 3 where certain obstructions can cause sounds to behave how one might expect them to. Otherwise the sounds can carry at absurd distances and resonate as though you yourself are inside the cave. This is especially noticeable in the videos where the redstone contraptions are set out in the complete open and yet sound like they are in a cavern (this particular example does not work with mobs). If this is intended, how would you suggest mitigating this without compromising the quality of other aspects of the mod?

Log files https://gist.github.com/Peonovic/855445deb9c3042d022cdf81e9ac3d0e

Versions

Other mods Mods are not required to replicate and are not used in videos, but modded objects and mobs are also affected (for example the open field example works with some Create elements).

Videos 1 - https://streamable.com/mhfgf7 2 - https://streamable.com/yg3jrt 3 - https://streamable.com/1bclmx 4 - https://streamable.com/7tv7t8 5 - https://streamable.com/3qtacn 6 - https://streamable.com/wrmhqd 7 - https://streamable.com/83i2bo

henkelmax commented 11 months ago

When making videos about weird sound behavior, please always enable the debug visualization. I can't help you without seeing what the sound rays are doing.

Peonovic commented 11 months ago

I'm sorry, guess I didn't think about it. If you like I can replicate all of them and repost here?

henkelmax commented 11 months ago

Sure. But please make sure you only show things you can't explain by the sound rays.

Peonovic commented 11 months ago

Hah. Apologies for my ignorance but just to verify what exactly you mean before I waste our time with more videos you can't make use of, do you simply mean the F3 screen, debug profiling, or something else I'm unaware of?

henkelmax commented 11 months ago

You'll find the settings in the debug tab of the the config GUI.

Peonovic commented 11 months ago

Hopefully these are more useful.

New Log https://gist.github.com/Peonovic/b9d35e25f870458c245640023ba9e6a5

Videos 1 - https://streamable.com/mrrll4 2 - https://streamable.com/dtkyrw 3 - https://streamable.com/5slpnq 4 - https://streamable.com/c0969b

henkelmax commented 11 months ago

I can't really see any issues in your videos. You can make the sound evaluation more precise by increasing the ray count, but that will always impact performance. You can also disable some functionalities in the config file if you are not happy with the directional evaluation.