henkelmax / sound-physics-remastered

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
69 stars 22 forks source link

Fix block position evaluation #215

Closed MUKSC closed 2 weeks ago

MUKSC commented 4 weeks ago

Fix weird muffling issues. Also changed variationFactor because keeping it to 0.501 caused sounds to phase through 1 block wall and never muffles.

https://github.com/henkelmax/sound-physics-remastered/assets/68376185/0cf8caf0-c8a8-4737-8de9-f7af7c46a0bc

henkelmax commented 2 weeks ago

Your fix doesn't actually fix the issue you have shown in the video.

henkelmax commented 2 weeks ago

Setting it to 0.49 seems to fix the issue you are having. It might cause other issues though. I have to further investigate this.

MUKSC commented 2 weeks ago

Oh, really? I should've done more testing. Sorry about that.

henkelmax commented 2 weeks ago

No worries, thanks for pointing out the issue!