henkelmax / sound-physics-remastered

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
76 stars 25 forks source link

There is considerable lag when many sounds are played concurrently #234

Closed AndreiToroplean closed 4 months ago

AndreiToroplean commented 4 months ago

Bug description

So for example if you have a pen containing many animals, all making noises, and you get close to it, Minecraft starts to lag.

I've looked through the mod's performance settings, and I've found no way to limit the total number of rays that exist at once. Reducing the number of rays per sound reduces the lag, but it's a shame to do that when most of the gameplay doesn't have that issue. I think that adding that setting could be a potential solution, especially since it's humanly difficult to make sense of many sounds at once and their places in space, so a drop in sound physics quality would probably not be very noticeable there.

Minecraft version

1.20.4

Mod version

fabric-1.20.4-1.4.5

Mod loader and version

Fabric Loader 0.16.0

Steps to reproduce

  1. Create a pen using fences
  2. Add many (>50) sheep inside it
  3. Get close to it -> starts lagging
  4. Get farther away -> when you can't hear the sheep, the lag is gone.

Expected behavior

No response

Log files

https://gist.github.com/AndreiToroplean/89e08472f69371014f489b343aa1c565

Videos

https://youtu.be/XodG4Acw3ak

henkelmax commented 4 months ago

This is completely normal. The mod does a LOT of processing for every sound. If you have sounds that are played a lot, I'd recommend blacklisting the sound from being processed by the mod. Other than that you can adjust the performance settings.

henkelmax commented 4 months ago

Also a duplicate of #227