search

henkelmax / sound-physics-remastered

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
69 stars 22 forks source link

CurseForge missing 1.0.6 version for Fabric #40

Closed PweSol closed 2 years ago

PweSol commented 2 years ago

Bug description There are only 1.0.6 latest builds for Forge and not for Fabric, I successfully built 1.0.6 version for Fabric from source and it's working fine. Are the new changes relevant only for the Forge version?

Steps to reproduce the issue

  1. Go to https://www.curseforge.com/minecraft/mc-mods/sound-physics-remastered
  2. No 1.0.6 version for Fabric (1.18.2). Only 1.0.5 when browsing the Files tab

Expected behavior 1.0.6 version for Fabric?

Log files N/A

Versions

Other mods N/A

Screenshots (Optional) here and here

henkelmax commented 2 years ago

Thanks for reporting this... No clue how I missed that... It should be approved by course in a couple of minutes.

PweSol commented 2 years ago

One more thing. The version compatibility is labeled to be 1.18.1. But I've been using it on 1.18.2 for a long time so it's most likely compatible and should probably be marked as such as well.

Edit: Also there is a commit for 1.18.2 so it's definitely updated.

henkelmax commented 2 years ago

Which version compatibility do you mean?

PweSol commented 2 years ago

You just changed it. It's fine now.

henkelmax commented 2 years ago

I didn't change anything

PweSol commented 2 years ago

Really? The page was showing "Game Version: 1.18.1" and the file that I downloaded is also named 1.18.1. But now I refreshed it and it's showing as 1.18.2, including the file. Although there seems to be now two files; for 1.18.1 and 1.18.2.

But it's not an issue anymore so whatever.

henkelmax commented 2 years ago

I uploaded 1.17.1, 1.18.1 and 1.18.2 Each file takes a while to get approved by curse, as I already said.