search

henkelmax / sound-physics-remastered

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
75 stars 24 forks source link

Fix issue where only 1 aux effect was being heard #50

Closed DaDerpDuck closed 2 years ago

DaDerpDuck commented 2 years ago

In SoundPhysics.setEnvironment, when a source's auxiliary feed is configured so an effect is heard, every auxiliary send number is conflictedly set to 1. This results in only the last effect of the 4 to be heard (which happens to be the effect with the largest reverb).

This fix allows all 4 reverb effects to be heard now, providing in theory a richer sound (personally I don't hear much of a dramatic difference due to the other 3 reverbs being much less intense, but at least the calculations for the gains/cutoffs are no longer in vain).

henkelmax commented 2 years ago

Thank you for your contribution!