henkelmax / sound-physics-remastered

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
75 stars 24 forks source link

when updated to 1.19.1, my framerates in nether started droping to 1 fps. #55

Closed twojamama1 closed 2 years ago

twojamama1 commented 2 years ago

when 1.19.1 came out i updated this mod from 1.19 to 1.19.1 and my framerates in nether started droping to 1 fps. without this mod minecraft works normally and i have abaut 100 fps. please fix this (p.s. it was on newest version of forge and on minecraft version 1.19.1)

Thats all i have.

henkelmax commented 2 years ago

Please fill out the bug template and provide logs.

twojamama1 commented 2 years ago

ok but minecraft didnt crash so how i am going to upload logs?

henkelmax commented 2 years ago

Logs are always there. You might be thinking of crash reports.

twojamama1 commented 2 years ago

Bug description when 1.19.1 came out i updated this mod from 1.19 to 1.19.1 and my framerates in nether started droping to 1 fps. without this mod minecraft works normally and i have abaut 100 fps.

Steps to reproduce the issue

  1. Go to nether.
  2. See error

Log files Where do i find logs?

Versions

Other mods Ambient Sounds Bookshelf Catalouge Configured CreativeCore DynamicLights EnchantmentDescriptions Jade Jei Just Zoom Konkrete MusicPlayer Oculus Rubidium U Team Core Xaero's Minimap Xaero's World Map (I tested without other mods if this issiue still appears and yes it still appears without other mods)

Screenshots https://cdn.discordapp.com/attachments/915232532918841404/1002989181099855912/unknown.png

henkelmax commented 2 years ago

does this also happen without ambient sounds? Also, don't forget the logs.

twojamama1 commented 2 years ago

yes it happens without ambients sounds. logs... where do i find them? because idk i am reporting a bug like this for the first time

henkelmax commented 2 years ago

logs/latest.log

twojamama1 commented 2 years ago

ok! wait a moment.

twojamama1 commented 2 years ago

when i created this log i only had sound physics running latest.log

henkelmax commented 2 years ago

Nothing unusual in the logs... I'm trying to reproduce it myself.

twojamama1 commented 2 years ago

but this log was made when I had all my mods on latest.log

twojamama1 commented 2 years ago

ok. i am wating

henkelmax commented 2 years ago

image

I'm getting the usual frame rates. Just to double check, can you try running your game without any mods? Can you also try joining a new world?

twojamama1 commented 2 years ago

i checked without any mods 10 times and still the same and ok i'm gonna do the new world

henkelmax commented 2 years ago

i checked without any mods 10 times and still the same and ok i'm gonna do the new world

So it happens without sound physics aswell?

twojamama1 commented 2 years ago

yes

henkelmax commented 2 years ago

Then it isn't an issue of the sound physics mod.

twojamama1 commented 2 years ago

wait no no

twojamama1 commented 2 years ago

without sound physics it dosent happend

twojamama1 commented 2 years ago

I was wrong I thought you wrote "without ambient sounds"

twojamama1 commented 2 years ago

can you come back??? @henkelmax

henkelmax commented 2 years ago

Calm down!

Did you use the same version back in 1.19?

twojamama1 commented 2 years ago

The same version of mod? i think no

henkelmax commented 2 years ago

Can you try that?

henkelmax commented 2 years ago

image Also tried it in the nether btw. Also no frame drops.

twojamama1 commented 2 years ago

i just checked and on new world it dosent happen

henkelmax commented 2 years ago

Weird. You might want to tone down the performance settings in the config menu. If you have many sound sources, it might be a little bit too heavy for lower spec pcs.

twojamama1 commented 2 years ago

my pereformance settings is on medium and my pc specs is really good

twojamama1 commented 2 years ago

its 2 years old computer

henkelmax commented 2 years ago

Medium? I'm talking about the sound physics settings.

twojamama1 commented 2 years ago

wait. there is one??

twojamama1 commented 2 years ago

where????

henkelmax commented 2 years ago

Either in the config, or via cloth config.

Just install cloth config for forge and click on the config button in the mods menu on the title screen.

twojamama1 commented 2 years ago

i have something familliar called ,,configured" and i dont have the config button image

twojamama1 commented 2 years ago

but in other mods (like jade) i have the config button.

image

henkelmax commented 2 years ago

It won't work without cloth config.

twojamama1 commented 2 years ago

ok i gonna try (p.s. sorry for my bad english but i live in poland. i am trying my best)

twojamama1 commented 2 years ago

what do i do now? image

henkelmax commented 2 years ago

Go to performance and set

that should be better for performance

twojamama1 commented 2 years ago

i did that and its still happening i have an idea. maybe i will send you link to my save and you will check why its happening?

henkelmax commented 2 years ago

I don't have the time for that. It looks like a performance issue. Just avoid a lot of sounds.

twojamama1 commented 2 years ago

but its happening all over the nether

twojamama1 commented 2 years ago

what is happening. why its happening only on my world

twojamama1 commented 2 years ago

i think i found what is causing this problem. When something is triggering an echo or something associated with sound physics it creates a lag spike and because there are a lot of sounds in the nether it creates a lot of lag

twojamama1 commented 2 years ago

and on the new world there was still a lag spickes but less becouse this was new world and there was less mobs

twojamama1 commented 2 years ago

i just asked my friend if he have the same problem with lag spickes on this version and he said yes. this proves it's the fault of some bug causing lag spickes in your mod

henkelmax commented 2 years ago

If you found a way to reliably reproduce the bug, let me know and I'll reopen the issue.

twojamama1 commented 2 years ago

@henkelmax i cant find anything. i tried so many ways and nothing is working. i think that you need to repair this in next update. i know that its happening becouse of lag spickes and it cant be fixed without fumbling in the code of this mod.

twojamama1 commented 2 years ago

i am waiting for the next update. if this not get fixed i am reopening this

henkelmax commented 2 years ago

It won't get fixed if I can't reproduce it. I can't fix a bug that I can't reproduce!