search

henkelmax / sound-physics-remastered

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
69 stars 22 forks source link

Sound occlusion removes almost all sound around corners #81

Closed spsquared closed 1 year ago

spsquared commented 1 year ago

Bug description If you build something really loud (like a lightning generator) and stand around a corner the sound almost completely disappears. All my settings were at default and I have no other mods that change the sound physics. It actually also works just by turning the camera so you can't see it anymore. I doubled the amount of rays used to calculate the sounds but I had to increase it to absurd levels to hear anything at all. I think the occlusion is too much because it's only 1 layer of blocks between me and the really loud sounds.

I turned on debug draw and none of the lines reach my player.

Steps to reproduce the issue

  1. Build really loud sound generator
  2. Build a wall (I used a building)
  3. Stand just behind the wall
  4. Can't hear the sound

Expected behavior The sound should propagate around the corner and sound a bit muffled, not be completely gone. I think the rays should be able to propagate through blocks more.

Log files No errors I also don't know where the debug logs are.

Versions

Other mods

Screenshots (Optional) image Very loud from here image Literally can't hear it here

henkelmax commented 1 year ago

Please include screenshots with debug rendering enabled. You find this in the debug section of the settings GUI of the mod.

spsquared commented 1 year ago

If I set up a bell to ring constantly outside my house and walk around inside it goes from really loud to completely silent.

spsquared commented 1 year ago

Screenshots with debug rendering enabled. Both environment rays and occlusion ray counts have been doubled. image Sound bounces, no occlusion rays, can hear image Occlusion rays, no sound bounces, can hear image Sound bounces, no occlusion rays, cannot hear image Occlusion rays, no sound bounces, cannot hear

Some extra rays exist because of the villagers. also I'm using bells instead of channeling tridents and lightning rods.

henkelmax commented 1 year ago

Can you send a recording of this?

spsquared commented 1 year ago

I'm getting less than 1 fps for some reason and the recording is basically a screenshot. Sorry, but I really don't know why my game just died.

spsquared commented 1 year ago

I increased the number of rays by a lot and it helps the issue a little bit, I have to be further around the wall to not hear it, but the performance isn't as good anymore.

henkelmax commented 1 year ago

That's the thing. There are only a limited number of rays. There will always be specific situations where it sounds weird, but there is simply not enough performance to do it perfectly.

spsquared commented 1 year ago

I would suggest making loud sounds like lightning always play without any processing, so situations like this where you're far away but realistically should still hear the sound don't happen as easily.