henkelmax / storage-overhaul

A complete overhaul of storage containers.
2 stars 9 forks source link

Storage barrel attempts to drop stacked unstackable items #14

Closed ChloeDawn closed 3 years ago

ChloeDawn commented 3 years ago

Bug description Internally, the storage barrel is forcibly stacking unstackable items rather than expanding the inventory size, and then when broken externally, attempts to pass this "illegal" item stack to InventoryHelper, which results in unreliable behaviour of 1-3 item stacks of varying counts of unstackable item types.

Steps to reproduce the issue

  1. Place unstackable items in barrel
  2. Destroy block externally (explosion, AoE tool, etc)
  3. Block will drop "illegal" item stacks

Expected behavior The block should drop each individual unstackable item, with no "illegal" counts merging them

Versions

Relevant code https://github.com/henkelmax/storage-overhaul/blob/fb2bf6cc5bac7e15e8ea96f19631f7c76e05135a/src/main/java/de/maxhenkel/storage/blocks/StorageBarrelBlock.java#L233

Screenshots Action performed with Thermal's Fluxsaw performing an AoE Screenshot of items in barrel Screenshot of items in inventory

henkelmax commented 3 years ago

Thank you for reporting this issue. It should be fixed in the latest version.