henkelmax / storage-overhaul

A complete overhaul of storage containers.
2 stars 9 forks source link

Placing named Advanced Shulkers in the world increases name length and can cause crashes #26

Open danjcollins opened 2 years ago

danjcollins commented 2 years ago

Bug description When you place down a named Advanced Shulker Box in the world, brackets get added to its name. If you do it repeatedly, the name can get long enough that it causes Minecraft to crash

Steps to reproduce the issue

  1. Name an advanced shulker box on an anvil (say "name")
  2. Place the advanced shulker box in the world and then break it. In your inventory it should now be named "[name]"
  3. Repeating (2) multiple times will get it to be named "[[[[[name]]]]]" and so on.
  4. Doing this enough will cause the game to crash via java.io.UTFDataFormatException or io.netty.handler.codec.EncoderException errors, presumably because the name is longer than the maximum expected length

Expected behavior The name of the advanced shulker box shouldn't change when placed down / broken

Log files https://gist.github.com/danjcollins/b24f9006af5c7cd6926e47140e58d0dd

Versions

Other mods None; first noticed the issue in the Vault Hunters modpack but reproduced in a fresh forge instance with just this mod.