search

henkelmax / trade-cycling

The trade cycling functionality of Easy Villagers.
11 stars 6 forks source link

Mod works on local world but not on hosted instance. #23

Closed Sylencia closed 8 months ago

Sylencia commented 9 months ago

Bug description I have Trade Cycling added on both server and client, but the mod only works once per session on the hosted instance. When I try the same thing on a local world the mod works fine.

Steps to reproduce the issue

  1. Add mod to hosted server. (and have it on client)
  2. Get a librarian with no trades done.
  3. Confirm you can do trade cycling.
  4. Close the window and open it again (without trading before closing).
  5. The trade cycling arrow no longer appears.

Expected behavior The trade cycling arrow should remain shown

Log files I have checked the logs but there was no output related to trade cycling. As mentioned, it also works fine on a local world. Let me know if I still need to have a log uploaded

Versions

Other mods A list of the other mods that were installed when this problem occurred. It would be ideal if you could test if this problem persists when no other mod is installed. If not, please narrow down the mod(s) that are causing the problem.

image

I have tested it on the server with nothing but Fabric API + Trade Cycling on that end. I have also tested it with the client only having Fabric API + Trade Cycling.

Screenshots (Optional) Screenshots of the issue.

henkelmax commented 9 months ago

Please provide logs, like stated in the template.

Sylencia commented 9 months ago

Client log can be found here: https://gist.github.com/Sylencia/eba75bcf317afc4a7f0885a9e49fbfb3 Server log can be found here: https://gist.github.com/Sylencia/a8732d8c671ed0761dd997772ed64be8

Example can be found in this video I quickly uploaded: https://youtu.be/SVbggJE1k68

henkelmax commented 9 months ago

I tried it on a server with just the mod installed and it works perfectly fine. Are there any steps needed to reproduce the issue?

Sylencia commented 9 months ago

I don't think so, I recently moved my server hosting but in both places it wasn't working. I do know the mod worked while I was in 1.20.1, but broke when I updated.

I'll try to give you my configuration setup to see if anything odd sticks out, but I will be away this weekend so I'll only be able to do it in a few days time

Sylencia commented 9 months ago

I'm wondering if there are any server configs I should look out for as far as you know - I tried an experiment today where I downloaded a backup of my server and ran it locally. This worked fine and the arrow was showing up as expected. Hopefully this narrows it down a little bit.

henkelmax commented 9 months ago

was your backup missing anything?

Sylencia commented 9 months ago

No it was a full backup. How does the trade button location config set the location? I couldn't find a place to set it and am wondering if maybe it's somehow changing from the default to none?

Sylencia commented 9 months ago

FWIW, the mod still works with the keybind setting - I only just tested that now after discovering it existed from the code 😆

henkelmax commented 9 months ago

Ok, so it seems to be a client side issue. Did you change any mods on the client or something when testing with the backup?

Sylencia commented 9 months ago

I tried to keep things consistent so I kept the mod list the same on the client when testing with the backup

henkelmax commented 9 months ago

Thats really weird... Can you try removing mods on the client until it works again, to find out which mod might be causing it?

Sylencia commented 9 months ago

I tried it with the client side having only Fabric API + Trade cycling and it seems to still only work in local. I've put the video here if you want to check my methodology: https://youtu.be/Px6X1EcdUmE

henkelmax commented 9 months ago

Thanks for the video. I'll try to reproduce it on an actual server.

henkelmax commented 9 months ago

Just tested it on a server with latest Fabric loader and latest mod version. Same on the client and it works fine. Even after reconnecting or restarting the game. Did you try connecting to another server with the mod or just test it with another villager in another area?

henkelmax commented 8 months ago

Closed due to inactivity.

EgorDoomsday commented 8 months ago

Also found this issue in my survival world. And got a "fix" for this. After logging into world, trade cycling button disappears after 1-2 seconds. Fixed this by disabling datapack "Blaze & Caves advancements" (or so) Some datapack funtions seems to be listening to villlager's trade GUI in order to count trades (There are some achievements like "trade X times") Also tried with only Fabric, Fabric API and Trade Cycling - same issue Minecraft 1.20.4 Fabric loader 0.15.6 Fabric API 0.95.4 Trade Cycling 1.0.11 No other datapacks except this one

Sylencia commented 8 months ago

That would probably explain it (sorry for the inactivity, I didn't realise there was another question posted). I do have the Blaze and Caves achievements data pack and that probably has conflicts. At least the hotkey works so that's good enough.