Possible conflict with SameDifferent's More Villagers

henkelmax / trade-cycling

The trade cycling functionality of Easy Villagers.

11 stars 6 forks source link

Possible conflict with SameDifferent's More Villagers #24

Closed Gamemassa closed 9 months ago

Gamemassa commented 9 months ago

Bug description

Not entirely sure if either Trade Cycling or More Villagers is causing it (or something else), but when I click on villagers, I don't see the cycle button.

Minecraft version

1.20.4

Mod version

1.20.4-1.0.7

Mod loader and version

Fabric Loader 0.15.7

Steps to reproduce

Load game with both More Villagers and Trade Cycling and open a villager's trade window.

Expected behavior

No response

Log files

N/A

Screenshots

No response

henkelmax commented 9 months ago

Can you send a screenshot of the trading GUI? You forgot to include your logs. Does pressing the cycle keybind work?

henkelmax commented 9 months ago

I just checked out the More Villagers mod and there's no version available for 1.20.4.

Gamemassa commented 9 months ago

I just checked out the More Villagers mod and there's no version available for 1.20.4.

The latest version of More Villagers is working for 1.20.4 (even though it doesn't say it on the mod page).

Gamemassa commented 9 months ago

Can you send a screenshot of the trading GUI?

You forgot to include your logs.

It wasn't causing a crash so not sure how the logs would help.

Does pressing the cycle keybind work?

Yes, the Cycle keybind still works. I was just hoping the GUI button issue might be fixable because then it wouldn't be mandatory to have a keybind for it.

henkelmax commented 9 months ago

The latest version of More Villagers is working for 1.20.4 (even though it doesn't say it on the mod page).

That might be the issue. You shouldn't use mods for versions its not supported for

Gamemassa commented 9 months ago

The latest version of More Villagers is working for 1.20.4 (even though it doesn't say it on the mod page).

That might be the issue. You shouldn't use mods for versions its not supported for

Actually, as of a minute ago, the issue has apparently fixed itself. The cycle button is now visible on both vanilla and modded villagers. I have absolutely no idea what caused the bug in the first place, or how I fixed it, but I did just make a new SP world because I added several more mods to my custom modpack (including almost all of YungNickYung's world-gen mods, which he just updated to 1.20.4) and all I can think is maybe something didn't load correctly in the previous world.