Mending being added back to the list of cycled trades even though its being disabled by other mods/datapacks - Githubissues

henkelmax / trade-cycling

The trade cycling functionality of Easy Villagers.

11 stars 6 forks source link

Mending being added back to the list of cycled trades even though its being disabled by other mods/datapacks #26

Closed silentSquid closed 6 months ago

silentSquid commented 6 months ago

Bug description

Hi there,

Sorry this is not really a bug but more of a compat issue so to say? I'm trying to disable mending being available from villagers in 1.20 and it looks like Trade Cycling is adding it back even though its being disabled by things like https://modrinth.com/mod/balancing-for-better or https://www.planetminecraft.com/data-pack/no-mending-offers Is there anything that can be done to prevent it? Thanks!

Minecraft version

1.20.1

Mod version

1.20.1-1.0.7

Mod loader and version

Fabric 15.7

Steps to reproduce

added trade cycling
added Balancing-For-Better mod or no mending datapacks
cycled trades a bunch
mending still appears in trades

Expected behavior

I don't want Mending to appear in cycled trades

Log files

n/a

Screenshots

No response

henkelmax commented 6 months ago

The mod does not change anything with villager trades. It just adds a button to cycle the trades, the same way as when removing the villagers workstation.