henkelmax / trade-cycling

The trade cycling functionality of Easy Villagers.
11 stars 6 forks source link

Trade cycle button disappears instantly #34

Closed Laguna726 closed 2 months ago

Laguna726 commented 2 months ago

Bug description

When opening a villager's trade menu, the cycle button shows up fine and functions properly the first time. However, after trading once it vanishes, and any attempt to reopen the menu to get it to reappear will result in it only showing up for a split second, making it impossible to use.

I saw that somebody had a similar issue on here, but after testing, this is the only mod I have enabled and no external mods or data packs are interfering with this mod's functionality. Also, I've noticed that other mods with this trade cycle feature tend to have the same issue, such as Wunderreich.

Minecraft version

1.21

Mod version

1.21.1-1.0.14

Mod loader and version

Fabric Loader 0.16.0

Steps to reproduce

Interact with a villager that has been previously traded with prior.

Expected behavior

When I open the villager trading menu at any point and after trading multiple times the trade cycle icon is meant to show up and function properly

Log files

https://gist.github.com/Laguna726/86a8f32440ecd5f766c280ef48989d6a#file-gistfile1-txt

Screenshots

Screenshot (66) Screenshot (67)

henkelmax commented 2 months ago

Thats the whole point. you cant cycle trades of a villager that has been traded with. Thats the same way it works in vanilla.