henkelmax / trade-cycling

The trade cycling functionality of Easy Villagers.
11 stars 6 forks source link

[1.18.2] Configs about Button Location #5

Closed INooBTooMuch closed 2 years ago

INooBTooMuch commented 2 years ago

Bug description I wanted to find the config file to change the button location (as is mentioned in the Curseforge page "Configurable trade cycling button location") but I wasn't able to find it in neither "config" not "serverconfig" folders so I use the Configured mod to do it in-game and then crashed. This might be a Feature for maybe only Fabric or 1.19.x but I didn't find anything more about it.

Steps to reproduce the issue

  1. Go to mods
  2. Select Trade Cycling config
  3. Change the location to None or Top Right
  4. Save Changes
  5. Crash

Log files Log I found this line here : Caused by: java.lang.NullPointerException: Cannot invoke "com.electronwill.nightconfig.core.UnmodifiableCommentedConfig.configFormat()" because "config" is null And on the Crash Screen : Error: java.lang.NullPointerException: Cannot invoke "com.electronwill.nightconfig.core.UnmodifiableCommentedConfig.configFormat()" because "config" is null

Versions

Other mods Happens also with these mods: Catalogue : 1.6.2 Configured : 1.5.4 Trade Cycling : 1.0.2

henkelmax commented 2 years ago

It seems that this crash happens with configured. Please try if it happens without that mod.

INooBTooMuch commented 2 years ago

Without that mod I wont be able to change the location, because I wan't able to find the config file for this mod. Tried searching for Trade and Cycling but only got the configs for other mods. Maybe the name is something else and then I wouldn't need to change them while in-game

henkelmax commented 2 years ago

You can't change the config ingame. You need to adjust it in the config file.

INooBTooMuch commented 2 years ago

I can't find the file inside the config or the serverconfig files. That's why I used Configured but it causes the crash. Do you know if the config doesn't load in 1.18.2 or the name isn't "trade-cycling" because searching it doesn't show up

henkelmax commented 2 years ago

config/trade_cycling-client.toml on your client.

INooBTooMuch commented 2 years ago

no doesn't show up

henkelmax commented 2 years ago

Its not on the server its on the client.

INooBTooMuch commented 2 years ago

yes im in the client \Instances\Challenger 1.18.2 Testing\config

henkelmax commented 2 years ago

No clue what you are doing, but for me its there 100%

INooBTooMuch commented 2 years ago

I will uninstall and reinstall and see if it appears

INooBTooMuch commented 2 years ago

I also tried with just trade cycling but this is the config folder: image image

I don't know why its not downloading the config file

henkelmax commented 2 years ago

Can you send me the logs of that instance?

INooBTooMuch commented 2 years ago

https://gist.github.com/INooBTooMuch/27d3cd7acc5d76a032bed946a3f45a53#file-just-trade-cycling-i-believe

henkelmax commented 2 years ago

Nope, everything works perfectly fine here.

INooBTooMuch commented 2 years ago

I have no idea what is happening, but I guess the button stays top_left

INooBTooMuch commented 2 years ago

If I download the config and put it in the config folder with the correct name will that work?

henkelmax commented 2 years ago

Nope

INooBTooMuch commented 2 years ago

is this [Render thread/INFO]: Deleting level trade cycle normal in the Log?