henkelmax / upload-curseforge-modpack-action

A GitHub action that uploads Minecraft modpacks to CurseForge
2 stars 5 forks source link

Server packs are not labeled as server packs #1

Open juraj-hrivnak opened 2 years ago

juraj-hrivnak commented 2 years ago

The issue:

My workflow: https://github.com/juraj-hrivnak/Underdog/blob/main/.github/workflows/Release.yml#L160

henkelmax commented 2 years ago

I already contacted curseforge for this, but they weren't helpful. Unfortunately ther is no officially documented way to mark a file as server pack.

If you know a way to do it, let me know.

juraj-hrivnak commented 2 years ago

Looking at the new curseforge API documentation, it seems there is a way now: https://docs.curseforge.com/?javascript#get-mod-files

"isServerPack": true,
henkelmax commented 2 years ago

This API requires an API key, so everyone wanting to use this would need to generate a separate API key

I also think this API is only meant to read data, not to upload stuff. But I currently don't have the time to take a look at it.

juraj-hrivnak commented 2 years ago

Hmm yeah, it's for reading data only. The upload API is here, and apparently, it doesn't support server packs, as you said. Adding this "isServerPack": true, to the metadata didn't work.

Thanks for your time and quick responses! I will fix this temporary by just adding a manifest to the server pack.