henkmollema / Dapper-FluentMap

Provides a simple API to fluently map POCO properties to database columns when using Dapper.
MIT License
429 stars 88 forks source link

Fix to Map Value Objects #58

Closed nicolastakashi closed 7 years ago

nicolastakashi commented 7 years ago

Based on the code snippet that @g-adolph put on issue #46 discussion thread.

Now we can map properties of value objects.

henkmollema commented 7 years ago

@nicolastakashi thanks for this! Have you verified that Dapper maps the columns to the desired value object?

nicolastakashi commented 7 years ago

Yes @henkmollema I wrote a test to verify the type mapped. And everything looks like good

henkmollema commented 7 years ago

@nicolastakashi you might want to check your Git settings because you've been committing with different usernames/email addresses.

nicolastakashi commented 7 years ago

I did not change my username or email.

I just checked and everything seems like before.

henkmollema commented 7 years ago

Take a look at the two commits here: https://github.com/henkmollema/Dapper-FluentMap/pull/58/commits. They show a different user with a different email address (and profile picture).

nicolastakashi commented 7 years ago

Ow Really!

Something strange with Github, because the only thing I just did was actually change my profile picture, nothing more.

Do not know exactly where to fix it?

Any suggestion?

nicolastakashi commented 7 years ago

If you search by my name you will see that only my profile appears.

nicolastakashi commented 7 years ago

Would you like me to pull a pull request again?

Do you think this is an impediment?

henkmollema commented 7 years ago

No it's fine. Please fix the remaining comment and I'll merge this in.

nicolastakashi commented 7 years ago

Which comment do you need to fix? Sorry, I do not understand very well.

henkmollema commented 7 years ago

There is one FirstOrDefault() left which should be [0] in stead.

lepiroupo commented 7 years ago

this version is already on nuget?

henkmollema commented 7 years ago

@lepiroupo @nicolastakashi I've just pushed v1.5.4 to NuGet: https://www.nuget.org/packages/Dapper.FluentMap/1.5.4.