Change DeleteMultiple and DeleteAll return type

henkmollema / Dommel

CRUD operations with Dapper made simple.

MIT License

634 stars 100 forks source link

Change DeleteMultiple and DeleteAll return type #197

Closed confcore closed 4 years ago

confcore commented 4 years ago

My suggestion is to return the number of rows deleted in methods DeleteMultiple, DeleteMultipleAsync, DeleteAll and DeleteAllAsync. This is a very good and common practice, it helps for logging affected (deleted) rows and other purposes without the need for additional requests.

confcore commented 4 years ago

If in version 2 it is important not to break backward compatibility, then I will not change the original methods, but add new ones.

henkmollema commented 4 years ago

Seems reasonable, thanks!