search

henkmollema / Dommel

CRUD operations with Dapper made simple.
MIT License
634 stars 100 forks source link

add CancellationToken in Delete statment #272

Closed DanieleSky closed 3 years ago

DanieleSky commented 3 years ago

Hi @henkmollema, I've added the cancellation token on Delete async method

codecov[bot] commented 3 years ago

Codecov Report

Merging #272 (7338bc7) into master (67cef37) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   79.12%   79.12%           
=======================================
  Files          32       32           
  Lines        1188     1188           
  Branches      136      136           
=======================================
  Hits          940      940           
  Misses        213      213           
  Partials       35       35
Impacted Files Coverage Δ
src/Dommel/Delete.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67cef37...7338bc7. Read the comment docs.

henkmollema commented 3 years ago

Thanks @DanieleSky! With the previous change I discovered the hard way - once again - that adding an optional parameter is a binary breaking change. However since this change only applies to the Delete-methods, I think the impact is fairly limited and does not warrant a major version bump.