Passing parameters into `Get()`

henkmollema / Dommel

CRUD operations with Dapper made simple.

MIT License

634 stars 100 forks source link

Passing parameters into `Get()` #93

Closed DamienLaw closed 5 years ago

DamienLaw commented 5 years ago

I'm referring to the file DommelMapper.Get.cs which I have attached as a screenshot. On line 86, the transaction is passed in as a parameter to Get<TEntity>() if ids.Length == 1.

However, on line 91, the transaction isn't passed in to QueryFirstOrDefault<TEntity>(). I think it's useful to pass the transaction in since it may have an isolation level of RepeatableRows or Serializable.

On the same note, is there a way for us to pass in the CommandTimeout as well?

henkmollema commented 5 years ago

That seems like a mistake or copy/paste error. Would you like to send a PR to fix it?

Regarding the command timeout: I don't think I would like to add the parameter to all the Dommel methods. I think it makes more sens to set the global SqlMapper.Settings.CommandTimeout setting of Dapper.