search

hennedo / escpos

golang library for espos printers, supporting images, barcodes and qr codes
MIT License
74 stars 30 forks source link

Use golang native iconv library instead of gnu iconv #14

Open justinmichaelvieira opened 1 year ago

justinmichaelvieira commented 1 year ago

@hennedo, when you get a chance, can you take a look at this?

Removes github.com/qiniu/iconv in favor of github.com/justinmichaelvieira/iconv.

https://github.com/justinmichaelvieira/iconv is my fork of (current) https://github.com/mushroomsir/iconv, with CP850 support added (I would wager CP850 support was what you saw missing, when you attempted the same, so I added it in and added a test case on my fork; Opened a PR there as well, but for now the fork seems to work).

https://github.com/mushroomsir/iconv/pull/3/commits/6b19bf09f613edd668e38601ffb53e965237c9eb is the relevant commit adding CP850 to go native iconv lib.

Fixes https://github.com/hennedo/escpos/issues/11

justinmichaelvieira commented 10 months ago

@hennedo just pinging you as a gentle reminder to please take a look if you get a chance. I think removing the CGO dependency greatly increases the utility of this lib.

justinmichaelvieira commented 6 months ago

@hennedo this should be very safe to merge at this point, a few other developers in this repo have said they have tested and are using my fork, which is equivalent to this PR, currently, just so they can save themselves hassle of compiling the gnu iconv dependency, and I've been using it successfully for >1yr at this point without issue.

abdullah-hallaq commented 2 months ago

When this can be marged

justinmichaelvieira commented 2 months ago

When this can be marged

@abdullah-hallaq feel free to use my fork (https://github.com/justinmichaelvieira/escpos) until @hennedo gets a chance to review and merge it here. I have merged it there.

abdullah-hallaq commented 2 months ago

Thank you @justinmichaelvieira