henninghall / react-native-date-picker

React Native Date Picker is datetime picker for Android and iOS. It includes date, time and datetime picker modes. The datepicker is customizable and is supporting different languages. It's written with native code to achieve the best possible look, feel and performance.
MIT License
2.13k stars 325 forks source link

Title, Confirm and Cancel in Dark mode is not visible #720

Open theDevSoham opened 8 months ago

theDevSoham commented 8 months ago

Describe the bug Only tested on android: The dark mode text for the calendar is not changing color with theme change.

Expected behavior To be set to white when in dark mode or preferably should take a customizalbe React.Fragment instead of a string

To Reproduce Add example code that reproduces the behavior.

export default class App extends Component {

  state = { date: new Date() }

  render = () =>
    <DatePicker
                modal
                open={true}
                date={state }
                onConfirm={(d) => {
                  console.log("Date changed: ", d)
                }}
                onCancel={() => {
                  console.log("Cancelled: ")
                }}
                theme="dark"
                title="Select Date"
              />

}

Smartphone (please complete the following information):

image

image

theDevSoham commented 8 months ago

@henninghall please check

brandon-austin-lark commented 7 months ago

Same issue here

cyrilmarceau commented 7 months ago

Same issue but only on google device. I have tested on a samsung s10e and problem will not appear

pranjal-easy-peasy commented 7 months ago

We've had to work around this by using theme="light" but it would be great to get this fixed.

theDevSoham commented 7 months ago

theme="light" actually works fine...there's only some issue with dark mode heading and bottom buttons. It really needs some fix.

z1haze commented 6 months ago

This same issue exists for me with the date picker fields. This can be seen in #734

mkhoussid commented 2 months ago

Is there a planned fix or we might as well fork this repo and do it ourselves?

henninghall commented 2 months ago

PRs are welcome!

vinamrahalgar commented 5 days ago

cancelText does it work for iOS as well?